chrome/browser/web_applications/web_app_win.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_applications/web_app_win.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/web_applications/web_app_win.cc

diff --git a/chrome/browser/web_applications/web_app_win.cc b/chrome/browser/web_applications/web_app_win.cc

index 98137b214ec391cda6e6def1159f950627dcb757..fe26bca227a8c8a88764e1473602c39098bd93f7 100644

--- a/chrome/browser/web_applications/web_app_win.cc

+++ b/chrome/browser/web_applications/web_app_win.cc

@@ -53,7 +53,6 @@ void GetImageCheckSum(const gfx::ImageFamily& image, base::MD5Digest* digest) {

++it) {

SkBitmap bitmap = it->AsBitmap();

- SkAutoLockPixels image_lock(bitmap);

base::StringPiece image_data(

reinterpret_cast<const char*>(bitmap.getPixels()), bitmap.getSize());

base::MD5Update(&md5_context, image_data);