chrome/browser/extensions/bookmark_app_helper_unittest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/bookmark_app_helper_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: fix mac Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/bookmark_app_helper_unittest.cc

diff --git a/chrome/browser/extensions/bookmark_app_helper_unittest.cc b/chrome/browser/extensions/bookmark_app_helper_unittest.cc

index 53270817d95ed82d8db23f0b4c581cab17e7405d..87c99eff3270ff4d067a9e55c2af403045fc17ee 100644

--- a/chrome/browser/extensions/bookmark_app_helper_unittest.cc

+++ b/chrome/browser/extensions/bookmark_app_helper_unittest.cc

@@ -105,7 +105,6 @@ BookmarkAppHelper::BitmapAndSource CreateSquareBitmapAndSourceWithColor(

void ValidateBitmapSizeAndColor(SkBitmap bitmap, int size, SkColor color) {

// Obtain pixel lock to access pixels.

- SkAutoLockPixels lock(bitmap);

EXPECT_EQ(color, bitmap.getColor(0, 0));

EXPECT_EQ(size, bitmap.width());

EXPECT_EQ(size, bitmap.height());