Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: cc/output/gl_renderer.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: fix mac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | cc/output/renderer_pixeltest.cc » ('j') | cc/resources/ui_resource_bitmap.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/gl_renderer.cc
diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc
index 612c31564878454e01636cf365f22a615440907e..ed0d94c58f52e46544e980dc80a89610dcccc5bc 100644
--- a/cc/output/gl_renderer.cc
+++ b/cc/output/gl_renderer.cc
@@ -2825,7 +2825,6 @@ void GLRenderer::FinishedReadback(unsigned source_buffer,
if (src_pixels) {
bitmap.reset(new SkBitmap);
bitmap->allocN32Pixels(size.width(), size.height());
- std::unique_ptr<SkAutoLockPixels> lock(new SkAutoLockPixels(*bitmap));
uint8_t* dest_pixels = static_cast<uint8_t*>(bitmap->getPixels());
size_t row_bytes = size.width() * 4;
« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | cc/output/renderer_pixeltest.cc » ('j') | cc/resources/ui_resource_bitmap.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698