Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: ui/base/clipboard/clipboard_android.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebImageTest.cpp ('k') | ui/base/clipboard/clipboard_test_template.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/clipboard/clipboard_android.cc
diff --git a/ui/base/clipboard/clipboard_android.cc b/ui/base/clipboard/clipboard_android.cc
index 1761d6c35e97d96558985cdabaf27963fe43b39b..b33b78fcd7fcadcd517ef93cab653c0056408ee9 100644
--- a/ui/base/clipboard/clipboard_android.cc
+++ b/ui/base/clipboard/clipboard_android.cc
@@ -498,11 +498,8 @@ void ClipboardAndroid::WriteBitmap(const SkBitmap& bitmap) {
gfx::Size size(bitmap.width(), bitmap.height());
std::string packed(reinterpret_cast<const char*>(&size), sizeof(size));
- {
- SkAutoLockPixels bitmap_lock(bitmap);
- packed += std::string(static_cast<const char*>(bitmap.getPixels()),
- bitmap.getSize());
- }
+ packed += std::string(static_cast<const char*>(bitmap.getPixels()),
+ bitmap.getSize());
g_map.Get().Set(kBitmapFormat, packed);
}
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebImageTest.cpp ('k') | ui/base/clipboard/clipboard_test_template.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698