third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp b/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

index 41c4c12421a4ab00a403f5e8c1b5db54dba55166..a26594466b40fd22c60878b786095b05772c5a92 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp

@@ -48,9 +48,6 @@ ImageFrame& ImageFrame::operator=(const ImageFrame& other) {

return *this;

bitmap_ = other.bitmap_;

- // Keep the pixels locked since we will be writing directly into the

- // bitmap throughout this object's lifetime.

- bitmap_.lockPixels();

// Be sure to assign this before calling setStatus(), since setStatus() may

// call notifyBitmapIfPixelsChanged().

pixels_changed_ = other.pixels_changed_;