skia/ext/platform_canvas_unittest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/ext/platform_canvas_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/ext/platform_canvas_unittest.cc

diff --git a/skia/ext/platform_canvas_unittest.cc b/skia/ext/platform_canvas_unittest.cc

index 1bd15a6bb9035e79eab832daa46e6a152f49fb6e..8d7e5979fd94309a71b6f3eb7b81f65beda708b8 100644

--- a/skia/ext/platform_canvas_unittest.cc

+++ b/skia/ext/platform_canvas_unittest.cc

@@ -58,7 +58,6 @@ bool VerifyRect(const SkCanvas& canvas,

uint32_t canvas_color, uint32_t rect_color,

int x, int y, int w, int h) {

const SkBitmap bitmap = skia::ReadPixels(const_cast<SkCanvas*>(&canvas));

- SkAutoLockPixels lock(bitmap);

for (int cur_y = 0; cur_y < bitmap.height(); cur_y++) {

for (int cur_x = 0; cur_x < bitmap.width(); cur_x++) {