printing/emf_win.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: printing/emf_win.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: printing/emf_win.cc

diff --git a/printing/emf_win.cc b/printing/emf_win.cc

index 1bcc75d946f9b8d55e8df1639ac13f3779cf78a9..9bd3e1eed20e36a624293e13cb43333d3b326705 100644

--- a/printing/emf_win.cc

+++ b/printing/emf_win.cc

@@ -382,7 +382,6 @@ bool Emf::Record::SafePlayback(Emf::EnumerationContext* context) const {

} else {

DCHECK(bitmap.get());

if (bitmap.get()) {

- SkAutoLockPixels lock(*bitmap.get());

DCHECK_EQ(bitmap->colorType(), kN32_SkColorType);

const uint32_t* pixels =

static_cast<const uint32_t*>(bitmap->getPixels());