content/shell/test_runner/test_runner.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/test_runner/test_runner.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/test_runner/test_runner.cc

diff --git a/content/shell/test_runner/test_runner.cc b/content/shell/test_runner/test_runner.cc

index b2201f4bddfcc33b27c4d28fa291cdd7a4f733f3..3feadb7db1bd093ee2d0c77c9416cdfc96eb6824 100644

--- a/content/shell/test_runner/test_runner.cc

+++ b/content/shell/test_runner/test_runner.cc

@@ -1800,10 +1800,7 @@ void TestRunner::DumpPixelsAsync(

// Return a blank image so that the test fails.

SkBitmap bitmap;

bitmap.allocN32Pixels(1, 1);

- {

- SkAutoLockPixels lock(bitmap);

- bitmap.eraseColor(0);

- }

+ bitmap.eraseColor(0);

callback.Run(bitmap);

return;

}