Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_android.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_android.cc b/content/browser/renderer_host/render_widget_host_view_android.cc
index b752011ae1d60065129ac9a5405e8e90cd5fe146..4c3471fde722dc6d7b8a3d9a89cf588eeb55c98c 100644
--- a/content/browser/renderer_host/render_widget_host_view_android.cc
+++ b/content/browser/renderer_host/render_widget_host_view_android.cc
@@ -284,12 +284,10 @@ void CopyFromCompositingSurfaceFinished(
std::unique_ptr<cc::SingleReleaseCallback> release_callback,
std::unique_ptr<SkBitmap> bitmap,
const base::TimeTicks& start_time,
- std::unique_ptr<SkAutoLockPixels> bitmap_pixels_lock,
scoped_refptr<PendingReadbackLock> readback_lock,
bool result) {
TRACE_EVENT0(
"cc", "RenderWidgetHostViewAndroid::CopyFromCompositingSurfaceFinished");
- bitmap_pixels_lock.reset();
gpu::SyncToken sync_token;
if (result) {
display_compositor::GLHelper* gl_helper = GetPostReadbackGLHelper();
@@ -383,8 +381,6 @@ void PrepareTextureCopyOutputResult(
return;
}
- std::unique_ptr<SkAutoLockPixels> bitmap_pixels_lock(
- new SkAutoLockPixels(*bitmap));
uint8_t* pixels = static_cast<uint8_t*>(bitmap->getPixels());
ignore_result(scoped_callback_runner.Release());
@@ -394,7 +390,7 @@ void PrepareTextureCopyOutputResult(
gfx::Rect(result->size()), output_size_in_pixel, pixels, color_type,
base::Bind(&CopyFromCompositingSurfaceFinished, callback,
base::Passed(&release_callback), base::Passed(&bitmap),
- start_time, base::Passed(&bitmap_pixels_lock), readback_lock),
+ start_time, readback_lock),
display_compositor::GLHelper::SCALER_QUALITY_GOOD);
}

Powered by Google App Engine
This is Rietveld 408576698