content/browser/devtools/devtools_frame_trace_recorder.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/devtools_frame_trace_recorder.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/devtools/devtools_frame_trace_recorder.cc

diff --git a/content/browser/devtools/devtools_frame_trace_recorder.cc b/content/browser/devtools/devtools_frame_trace_recorder.cc

index d0977b7e75ea03b9ed7c57c8e83a65c89aad9037..06b3dc0759fc5ee83d40eb1a7cdbbdd9c033dd30 100644

--- a/content/browser/devtools/devtools_frame_trace_recorder.cc

+++ b/content/browser/devtools/devtools_frame_trace_recorder.cc

@@ -40,7 +40,6 @@ class TraceableDevToolsScreenshot

out->append("\"");

if (!frame_.drawsNothing()) {

std::vector<unsigned char> data;

- SkAutoLockPixels lock_image(frame_);

bool encoded = gfx::JPEGCodec::Encode(

reinterpret_cast<unsigned char*>(frame_.getAddr32(0, 0)),

gfx::JPEGCodec::FORMAT_SkBitmap,