chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

index 4ff581cf054632996e98885747a5d86470503f65..bc73e8824a1f3ac45dd9ac463db5f66771103a18 100644

--- a/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc

@@ -551,9 +551,6 @@ TEST_F(BackFwdMenuModelTest, FaviconLoadTest) {

SkBitmap default_icon_bitmap = *default_icon.ToSkBitmap();

SkBitmap valid_icon_bitmap = *valid_icon.ToSkBitmap();

- SkAutoLockPixels a(new_icon_bitmap);

- SkAutoLockPixels b(valid_icon_bitmap);

- SkAutoLockPixels c(default_icon_bitmap);

// Verify we did not get the default favicon.

EXPECT_NE(0, memcmp(default_icon_bitmap.getPixels(),

valid_icon_bitmap.getPixels(),