Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Unified Diff: chrome/browser/thumbnails/content_analysis.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/thumbnails/content_analysis.cc
diff --git a/chrome/browser/thumbnails/content_analysis.cc b/chrome/browser/thumbnails/content_analysis.cc
index c795b1f1108c33d1cca8ccd022c8729ac1976a38..70743e61c50cf04c7e72092e5a034d643547c2b2 100644
--- a/chrome/browser/thumbnails/content_analysis.cc
+++ b/chrome/browser/thumbnails/content_analysis.cc
@@ -234,7 +234,6 @@ void ApplyGaussianGradientMagnitudeFilter(SkBitmap* input_bitmap,
// The purpose of this function is to highlight salient
// (attention-attracting?) features of the image for use in image
// retargeting.
- SkAutoLockPixels source_lock(*input_bitmap);
DCHECK(input_bitmap);
DCHECK(input_bitmap->getPixels());
DCHECK_EQ(kAlpha_8_SkColorType, input_bitmap->colorType());
@@ -383,7 +382,6 @@ void ExtractImageProfileInformation(const SkBitmap& input_bitmap,
bool apply_log,
std::vector<float>* rows,
std::vector<float>* columns) {
- SkAutoLockPixels source_lock(input_bitmap);
DCHECK(rows);
DCHECK(columns);
DCHECK(input_bitmap.getPixels());
@@ -664,7 +662,6 @@ void ConstrainedProfileSegmentation(const std::vector<float>& row_profile,
SkBitmap ComputeDecimatedImage(const SkBitmap& bitmap,
const std::vector<bool>& rows,
const std::vector<bool>& columns) {
- SkAutoLockPixels source_lock(bitmap);
DCHECK(bitmap.getPixels());
DCHECK_GT(bitmap.bytesPerPixel(), 0);
DCHECK_EQ(bitmap.width(), static_cast<int>(columns.size()));
« no previous file with comments | « chrome/browser/themes/browser_theme_pack_unittest.cc ('k') | chrome/browser/thumbnails/content_analysis_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698