chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/thumbnail/thumbnail_cache.cc ('k') | chrome/browser/chromeos/login/screenshot_testing/SkDiffPixelsMetric_cpu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

diff --git a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

index 5511e7eae4fd92401d2592e09826f6b574a28984..ae08305aba940c292907ab7a805d06327fb85ce2 100644

--- a/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

+++ b/chrome/browser/chromeos/accessibility/accessibility_highlight_manager_interactive_uitest.cc

@@ -92,8 +92,6 @@ class AccessibilityHighlightManagerTest : public InProcessBrowserTest {

void ComputeImageStats() {

diff_count_ = 0;

double accum[4] = {0, 0, 0, 0};

- SkAutoLockPixels lock_before(before_bmp_);

- SkAutoLockPixels lock_after(after_bmp_);

for (int x = 0; x < before_bmp_.width(); ++x) {

for (int y = 0; y < before_bmp_.height(); ++y) {

SkColor before_color = before_bmp_.getColor(x, y);

@@ -139,7 +137,6 @@ class AccessibilityHighlightManagerTest : public InProcessBrowserTest {

run_loop_quitter_ = run_loop.QuitClosure();

run_loop.Run();

SkBitmap bitmap = image_.AsBitmap();

- SkAutoLockPixels lock(bitmap);

if (bitmap.width() != bounds.width() ||

bitmap.height() != bounds.height()) {

LOG(INFO) << "Bitmap not correct size, trying to capture again";