Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3809)

Unified Diff: cc/test/pixel_comparator.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/resources/ui_resource_bitmap.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/test/pixel_comparator.cc
diff --git a/cc/test/pixel_comparator.cc b/cc/test/pixel_comparator.cc
index 4b4318899b14742884a66ca88a83b03626b7382c..229235b505c4233842bc79a214fe1900470a41ae 100644
--- a/cc/test/pixel_comparator.cc
+++ b/cc/test/pixel_comparator.cc
@@ -28,9 +28,6 @@ bool ExactPixelComparator::Compare(const SkBitmap& actual_bmp,
DCHECK(actual_bmp.width() == expected_bmp.width() &&
actual_bmp.height() == expected_bmp.height());
- SkAutoLockPixels lock_actual_bmp(actual_bmp);
- SkAutoLockPixels lock_expected_bmp(expected_bmp);
-
for (int x = 0; x < actual_bmp.width(); ++x) {
for (int y = 0; y < actual_bmp.height(); ++y) {
SkColor actual_color = actual_bmp.getColor(x, y);
@@ -96,9 +93,6 @@ bool FuzzyPixelComparator::Compare(const SkBitmap& actual_bmp,
// Check that bitmaps are not empty.
DCHECK(actual_bmp.width() > 0 && actual_bmp.height() > 0);
- SkAutoLockPixels lock_actual_bmp(actual_bmp);
- SkAutoLockPixels lock_expected_bmp(expected_bmp);
-
for (int x = 0; x < actual_bmp.width(); ++x) {
for (int y = 0; y < actual_bmp.height(); ++y) {
SkColor actual_color = actual_bmp.getColor(x, y);
« no previous file with comments | « cc/resources/ui_resource_bitmap.cc ('k') | cc/trees/layer_tree_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698