cc/output/gl_renderer.cc - Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/gl_renderer.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)

Patch Set: win fix after rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/output/gl_renderer.cc

diff --git a/cc/output/gl_renderer.cc b/cc/output/gl_renderer.cc

index 3446cc7d7214fa82c136451b5bc62837bd99648f..a7fe4528c8a5dd0b581736e6811c6eda19c1ec94 100644

--- a/cc/output/gl_renderer.cc

+++ b/cc/output/gl_renderer.cc

@@ -2830,7 +2830,6 @@ void GLRenderer::FinishedReadback(unsigned source_buffer,

if (src_pixels) {

bitmap.reset(new SkBitmap);

bitmap->allocN32Pixels(size.width(), size.height());

- std::unique_ptr<SkAutoLockPixels> lock(new SkAutoLockPixels(*bitmap));

uint8_t* dest_pixels = static_cast<uint8_t*>(bitmap->getPixels());

size_t row_bytes = size.width() * 4;

« no previous file with comments | « cc/layers/scrollbar_layer_unittest.cc ('k') | cc/output/renderer_pixeltest.cc » ('j') | no next file with comments »