SkBitmap and SkPixelRef no longer need lock/unlock

chrome/browser/media/webrtc/tab_desktop_media_list_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/media/webrtc/tab_desktop_media_list.h"
 
 #include "base/command_line.h"
 #include "base/files/file_util.h"
 #include "base/location.h"
 #include "base/run_loop.h"
@@ skipping 44 matching lines @@
     }
     return new TestingProfile(file_path, NULL);
   }
 };
 
 // Create a greyscale image with certain size and grayscale value.
 gfx::Image CreateGrayscaleImage(gfx::Size size, uint8_t greyscale_value) {
   SkBitmap result;
   result.allocN32Pixels(size.width(), size.height(), true);
 
-  result.lockPixels();
   uint8_t* pixels_data = reinterpret_cast<uint8_t*>(result.getPixels());
 
   // Set greyscale value for all pixels.
   for (int y = 0; y < result.height(); ++y) {
     for (int x = 0; x < result.width(); ++x) {
       pixels_data[result.rowBytes() * y + x * result.bytesPerPixel()] =
           greyscale_value;
       pixels_data[result.rowBytes() * y + x * result.bytesPerPixel() + 1] =
           greyscale_value;
       pixels_data[result.rowBytes() * y + x * result.bytesPerPixel() + 2] =
           greyscale_value;
       pixels_data[result.rowBytes() * y + x * result.bytesPerPixel() + 3] =
           0xff;
     }
   }
 
-  result.unlockPixels();
-
   return gfx::Image::CreateFrom1xBitmap(result);
 }
 
 }  // namespace
 
 class MockObserver : public DesktopMediaListObserver {
  public:
   MOCK_METHOD2(OnSourceAdded, void(DesktopMediaList* list, int index));
   MOCK_METHOD2(OnSourceRemoved, void(DesktopMediaList* list, int index));
   MOCK_METHOD3(OnSourceMoved,
@@ skipping 259 matching lines @@
   favicon_info.image = CreateGrayscaleImage(gfx::Size(10, 10), 100);
   contents->GetController().GetTransientEntry()->GetFavicon() = favicon_info;
 
   EXPECT_CALL(observer_, OnSourceThumbnailChanged(list_.get(), 0))
       .WillOnce(QuitMessageLoop());
 
   base::RunLoop().Run();
 
   list_.reset();
 }