Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: components/wallpaper/wallpaper_resizer_unittest.cc

Issue 2823003002: SkBitmap and SkPixelRef no longer need lock/unlock (Closed)
Patch Set: win fix after rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/wallpaper/wallpaper_resizer.h" 5 #include "components/wallpaper/wallpaper_resizer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 10
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 } 43 }
44 } 44 }
45 45
46 gfx::ImageSkia image = gfx::ImageSkia::CreateFrom1xBitmap(src); 46 gfx::ImageSkia image = gfx::ImageSkia::CreateFrom1xBitmap(src);
47 return image; 47 return image;
48 } 48 }
49 49
50 bool IsColor(const gfx::ImageSkia& image, const uint32_t expect) { 50 bool IsColor(const gfx::ImageSkia& image, const uint32_t expect) {
51 EXPECT_EQ(image.width(), kTargetWidth); 51 EXPECT_EQ(image.width(), kTargetWidth);
52 EXPECT_EQ(image.height(), kTargetHeight); 52 EXPECT_EQ(image.height(), kTargetHeight);
53 const SkBitmap* image_bitmap = image.bitmap(); 53 return *image.bitmap()->getAddr32(0, 0) == expect;
54 SkAutoLockPixels image_lock(*image_bitmap);
55 return *image_bitmap->getAddr32(0, 0) == expect;
56 } 54 }
57 55
58 } // namespace 56 } // namespace
59 57
60 namespace wallpaper { 58 namespace wallpaper {
61 59
62 class WallpaperResizerTest : public testing::Test, 60 class WallpaperResizerTest : public testing::Test,
63 public WallpaperResizerObserver { 61 public WallpaperResizerObserver {
64 public: 62 public:
65 WallpaperResizerTest() : worker_thread_("WallpaperResizerTest") {} 63 WallpaperResizerTest() : worker_thread_("WallpaperResizerTest") {}
(...skipping 90 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 task_runner()); 154 task_runner());
157 EXPECT_EQ(WallpaperResizer::GetImageId(image), resizer.original_image_id()); 155 EXPECT_EQ(WallpaperResizer::GetImageId(image), resizer.original_image_id());
158 resizer.AddObserver(this); 156 resizer.AddObserver(this);
159 resizer.StartResize(); 157 resizer.StartResize();
160 WaitForResize(); 158 WaitForResize();
161 resizer.RemoveObserver(this); 159 resizer.RemoveObserver(this);
162 EXPECT_EQ(WallpaperResizer::GetImageId(image), resizer.original_image_id()); 160 EXPECT_EQ(WallpaperResizer::GetImageId(image), resizer.original_image_id());
163 } 161 }
164 162
165 } // namespace ash 163 } // namespace ash
OLDNEW
« no previous file with comments | « components/wallpaper/wallpaper_manager_base.cc ('k') | content/browser/compositor/surface_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698