runtime/vm/kernel.cc - Issue 2822943002: [dart:io] Adds ProcessInfo.{max,current}Rss. Adds OS::MaxRSS on Fuchsia.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/kernel.cc

Issue 2822943002: [dart:io] Adds ProcessInfo.{max,current}Rss. Adds OS::MaxRSS on Fuchsia. (Closed)

Patch Set: Fix Fuchsia build Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/kernel.cc

diff --git a/runtime/vm/kernel.cc b/runtime/vm/kernel.cc

index 293f946592b9babbcaa7ebb65226015547d9a561..8c0e7884c5ef3dd6f47405ce09ba0185f9d2e4fd 100644

--- a/runtime/vm/kernel.cc

+++ b/runtime/vm/kernel.cc

@@ -80,7 +80,8 @@ bool CanonicalName::IsMember() {

// Note the two occurrences of the parameter 'literal'.

#define COMPARE_NAME(canonical_name, literal) \

- ((canonical_name)->name()->size() == strlen(literal) && \

+ ((canonical_name)->name()->size() == \

+ static_cast<intptr_t>(strlen(literal)) && \

memcmp((canonical_name)->name()->buffer(), (literal), strlen(literal)) == \