Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Unified Diff: chrome/browser/ui/webui/settings/languages_handler.cc

Issue 2822863002: MD Settings: Languages; limit platform specific code to the respective platform. (Closed)
Patch Set: Address @michaelpg feedback Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/languages_handler.cc
diff --git a/chrome/browser/ui/webui/settings/languages_handler.cc b/chrome/browser/ui/webui/settings/languages_handler.cc
index d3b4595cd0fcaac79349d74c27c9f9698a99b299..2f98827ad2d0c5acfb3eee378a90d8ddfb617f56 100644
--- a/chrome/browser/ui/webui/settings/languages_handler.cc
+++ b/chrome/browser/ui/webui/settings/languages_handler.cc
@@ -7,14 +7,11 @@
#include "base/bind.h"
#include "base/values.h"
#include "build/build_config.h"
-#include "chrome/browser/profiles/profile.h"
-#include "content/public/browser/web_ui.h"
-
-#if defined(OS_WIN) || defined(OS_CHROMEOS)
#include "chrome/browser/browser_process.h"
+#include "chrome/browser/profiles/profile.h"
#include "chrome/common/pref_names.h"
#include "components/prefs/pref_service.h"
-#endif
+#include "content/public/browser/web_ui.h"
#if defined(OS_CHROMEOS)
#include "chrome/browser/chromeos/profiles/profile_helper.h"
@@ -44,7 +41,6 @@ void LanguagesHandler::RegisterMessages() {
void LanguagesHandler::HandleGetProspectiveUILanguage(
const base::ListValue* args) {
-#if defined(OS_WIN) || defined(OS_CHROMEOS)
const base::Value* callback_id;
CHECK(args->Get(0, &callback_id));
@@ -62,9 +58,6 @@ void LanguagesHandler::HandleGetProspectiveUILanguage(
}
ResolveJavascriptCallback(*callback_id, base::Value(locale));
-#else
- NOTREACHED() << "Attempting to get locale on unsupported platform";
-#endif // defined(OS_WIN) || defined(OS_CHROMEOS)
}
void LanguagesHandler::HandleSetProspectiveUILanguage(
@@ -89,8 +82,6 @@ void LanguagesHandler::HandleSetProspectiveUILanguage(
profile_->ChangeAppLocale(language_code,
Profile::APP_LOCALE_CHANGED_VIA_SETTINGS);
}
-#else
- NOTREACHED() << "Attempting to set locale on unsupported platform";
#endif
}

Powered by Google App Engine
This is Rietveld 408576698