Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5610)

Unified Diff: chrome/browser/resources/settings/languages_page/languages_types.js

Issue 2822863002: MD Settings: Languages; limit platform specific code to the respective platform. (Closed)
Patch Set: Types Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/languages_page/languages_types.js
diff --git a/chrome/browser/resources/settings/languages_page/languages_types.js b/chrome/browser/resources/settings/languages_page/languages_types.js
index b4db7dbed1a376ac4923fc9d179c31abc40c4016..36d446f5fecbe98667a80466fb077bb47c6013d4 100644
--- a/chrome/browser/resources/settings/languages_page/languages_types.js
+++ b/chrome/browser/resources/settings/languages_page/languages_types.js
@@ -64,6 +64,7 @@ LanguageHelper.prototype = {
/** @return {!Promise} */
whenReady: assertNotReached,
michaelpg 2017/04/18 05:03:36 Would you mind re-ordering LanguageHelper's functi
dpapad 2017/04/18 18:31:20 I prefer to do this in the next CL https://coderev
+// <if expr="chromeos or is_win">
/**
* Sets the prospective UI language to the chosen language. This won't affect
* the actual UI language until a restart.
@@ -76,6 +77,7 @@ LanguageHelper.prototype = {
* @return {boolean}
*/
requiresRestart: assertNotReached,
+// </if>
/**
* @param {string} languageCode
@@ -159,12 +161,7 @@ LanguageHelper.prototype = {
*/
getLanguage: assertNotReached,
- /**
- * @param {string} id
- * @return {!chrome.languageSettingsPrivate.InputMethod|undefined}
- */
- getInputMethod: assertNotReached,
-
+// <if expr="chromeos">
/** @param {string} id */
addInputMethod: assertNotReached,
@@ -188,4 +185,5 @@ LanguageHelper.prototype = {
/** @param {string} id Input method ID. */
openInputMethodOptions: assertNotReached,
+// </if>
};

Powered by Google App Engine
This is Rietveld 408576698