MD Settings: Languages; limit platform specific code to the respective platform.

chrome/browser/resources/settings/languages_page/languages_page.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview 'settings-languages-page' is the settings page
  * for language and input method settings.
  */
 cr.exportPath('settings');
 
@@ skipping 24 matching lines @@
      * @type {!LanguagesModel|undefined}
      */
     languages: {
       type: Object,
       notify: true,
     },
 
     /** @type {!LanguageHelper} */
     languageHelper: Object,
 
+// <if expr="not is_macosx">
     /** @private */
     spellCheckSecondaryText_: {
       type: String,
       value: '',
       computed: 'getSpellCheckSecondaryText_(languages.enabled.*)',
     },
+// </if>
 
     /**
      * The language to display the details for.
      * @type {!LanguageState|undefined}
      * @private
      */
     detailLanguage_: Object,
 
     /** @private */
     showAddLanguagesDialog_: Boolean,
@@ skipping 12 matching lines @@
         map.set(
             settings.Route.INPUT_METHODS.path,
             '#inputMethodsCollapse .subpage-arrow');
 // </if>
         return map;
       },
     },
   },
 
   /**
-   * Handler for enabling or disabling spell check.
-   * @param {!{target: Element, model: !{item: !LanguageState}}} e
-   */
-  onSpellCheckChange_: function(e) {
-    var item = e.model.item;
-    if (!item.language.supportsSpellcheck)
-      return;
-
-    this.languageHelper.toggleSpellCheck(item.language.code,
-                                         !item.spellCheckEnabled);
-  },
-
-  /** @private */
-  onBackTap_: function() {
-    this.$.pages.back();
-  },
-
-  /**
    * Stamps and opens the Add Languages dialog, registering a listener to
    * disable the dialog's dom-if again on close.
    * @param {!Event} e
    * @private
    */
   onAddLanguagesTap_: function(e) {
     e.preventDefault();
     this.showAddLanguagesDialog_ = true;
     this.async(function() {
       var dialog = this.$$('settings-add-languages-dialog');
@@ skipping 42 matching lines @@
   },
 
   /**
    * @param {!Object} change Polymer change object for languages.enabled.*.
    * @return {boolean} True if there are less than 2 languages.
    */
   isHelpTextHidden_: function(change) {
     return this.languages.enabled.length <= 1;
   },
 
+// <if expr="chromeos">
+  /**
+   * Applies Chrome OS session tweaks to the menu.
+   * @param {!CrActionMenuElement} menu
+   * @private
+   */
+  tweakMenuForCrOs_: function(menu) {

[michaelpg, 2017/04/18 22:47:58]

nit: CrOS not CrOs (sorry to bikeshed, but it's CrOS everywhere in the code by
convention)

[dpapad, 2017/04/19 01:38:40]

Done.

+    // In a CrOS multi-user session, the primary user controls the UI language.
+    // TODO(michaelpg): The language selection should not be hidden, but should
+    // show a policy indicator. crbug.com/648498
+    if (this.isSecondaryUser_())
+      menu.querySelector('#uiLanguageItem').hidden = true;
+
+    // The UI language choice doesn't persist for guests.
+    if (uiAccountTweaks.UIAccountTweaks.loggedInAsGuest() ||
+        uiAccountTweaks.UIAccountTweaks.loggedInAsPublicAccount()) {
+      menu.querySelector('#uiLanguageItem').hidden = true;
+    }
+  },
+
+  /**
+   * Opens the Manage Input Methods page.
+   * @private
+   */
+  onManageInputMethodsTap_: function() {
+    settings.navigateTo(settings.Route.INPUT_METHODS);
+  },
+
+  /**
+   * Handler for tap and <Enter> events on an input method on the main page,
+   * which sets it as the current input method.
+   * @param {!{model: !{item: !chrome.languageSettingsPrivate.InputMethod},
+   *           target: !{tagName: string},
+   *           type: string,
+   *           key: (string|undefined)}} e
+   */
+  onInputMethodTap_: function(e) {
+    // Taps on the paper-icon-button are handled in onInputMethodOptionsTap_.
+    if (e.target.tagName == 'PAPER-ICON-BUTTON')
+      return;
+
+    // Ignore key presses other than <Enter>.
+    if (e.type == 'keypress' && e.key != 'Enter')
+      return;
+
+    // Set the input method.
+    this.languageHelper.setCurrentInputMethod(e.model.item.id);
+  },
+
+  /**
+   * Opens the input method extension's options page in a new tab (or focuses
+   * an existing instance of the IME's options).
+   * @param {!{model: !{item: chrome.languageSettingsPrivate.InputMethod}}} e
+   * @private
+   */
+  onInputMethodOptionsTap_: function(e) {
+    this.languageHelper.openInputMethodOptions(e.model.item.id);
+  },
+// </if>
+
+// <if expr="chromeos or is_win">
+  /**
+   * @return {boolean} True for a secondary user in a multi-profile session.
+   * @private
+   */
+  isSecondaryUser_: function() {
+    return cr.isChromeOS && loadTimeData.getBoolean('isSecondaryUser');
+  },
+
+  /**
+   * @param {string} languageCode The language code identifying a language.
+   * @param {string} prospectiveUILanguage The prospective UI language.
+   * @return {boolean} True if the prospective UI language is set to
+   *     |languageCode| but requires a restart to take effect.
+   * @private
+   */
+  isRestartRequired_: function(languageCode, prospectiveUILanguage) {
+    return prospectiveUILanguage == languageCode &&
+        this.languageHelper.requiresRestart();
+  },
+
   /**
    * @param {!LanguageState} languageState
    * @param {string} prospectiveUILanguage The chosen UI language.
    * @return {boolean} True if the given language cannot be set as the
    *     prospective UI language by the user.
    * @private
    */
   disableUILanguageCheckbox_: function(languageState, prospectiveUILanguage) {
     // UI language setting belongs to the primary user.
     if (this.isSecondaryUser_())
       return true;
 
     // If the language cannot be a UI language, we can't set it as the
     // prospective UI language.
     if (!languageState.language.supportsUI)
       return true;
 
     // Unchecking the currently chosen language doesn't make much sense.
     if (languageState.language.code == prospectiveUILanguage)
       return true;
 
     // Otherwise, the prospective language can be changed to this language.
     return false;
   },
 
   /**
-   * @return {boolean} True for a secondary user in a multi-profile session.
-   * @private
-   */
-  isSecondaryUser_: function() {
-    return cr.isChromeOS && loadTimeData.getBoolean('isSecondaryUser');
-  },
-
-  /**
    * Handler for changes to the UI language checkbox.
    * @param {!{target: !PaperCheckboxElement}} e
    * @private
    */
   onUILanguageChange_: function(e) {
     // We don't support unchecking this checkbox. TODO(michaelpg): Ask for a
     // simpler widget.
     assert(e.target.checked);
     this.languageHelper.setProspectiveUILanguage(
         this.detailLanguage_.language.code);
 
     this.closeMenuSoon_();
   },
+// </if>
 
   /**
    * @param {!chrome.languageSettingsPrivate.Language} language
    * @param {string} targetLanguageCode The default translate target language.
    * @return {boolean} True if the translate checkbox should be disabled.
    * @private
    */
   disableTranslateCheckbox_: function(language, targetLanguageCode) {
     if (!language.supportsTranslate)
       return true;
@@ skipping 59 matching lines @@
 
   /**
    * Disables the language.
    * @private
    */
   onRemoveLanguageTap_: function() {
     /** @type {!CrActionMenuElement} */(this.$.menu.get()).close();
     this.languageHelper.disableLanguage(this.detailLanguage_.language.code);
   },
 
+// <if expr="chromeos or is_win">
   /**
-   * Opens the Manage Input Methods page.
+   * Checks whether the prospective UI language (the pref that indicates what
+   * language to use in Chrome) matches the current language. This pref is used
+   * only on Chrome OS and Windows; we don't control the UI language elsewhere.
+   * @param {string} languageCode The language code identifying a language.
+   * @param {string} prospectiveUILanguage The prospective UI language.
+   * @return {boolean} True if the given language matches the prospective UI
+   *     pref (which may be different from the actual UI language).
    * @private
    */
-  onManageInputMethodsTap_: function() {
-    assert(cr.isChromeOS);
-    settings.navigateTo(settings.Route.INPUT_METHODS);
+  isProspectiveUILanguage_: function(languageCode, prospectiveUILanguage) {
+    return languageCode == prospectiveUILanguage;
   },
 
+ /**
+  * @param {string} prospectiveUILanguage
+  * @return {string}
+  * @private
+  */
+  getProspectiveUILanguageName_: function(prospectiveUILanguage) {
+    return this.languageHelper.getLanguage(prospectiveUILanguage).displayName;
+  },
+// </if>
+
   /**
-   * Handler for tap and <Enter> events on an input method on the main page,
-   * which sets it as the current input method.
-   * @param {!{model: !{item: !chrome.languageSettingsPrivate.InputMethod},
-   *           target: !{tagName: string},
-   *           type: string,
-   *           key: (string|undefined)}} e
+   * @return {string}
+   * @private
    */
-  onInputMethodTap_: function(e) {
-    assert(cr.isChromeOS);
-
-    // Taps on the paper-icon-button are handled in onInputMethodOptionsTap_.
-    if (e.target.tagName == 'PAPER-ICON-BUTTON')
-      return;
-
-    // Ignore key presses other than <Enter>.
-    if (e.type == 'keypress' && e.key != 'Enter')
-      return;
-
-    // Set the input method.
-    this.languageHelper.setCurrentInputMethod(e.model.item.id);
+  getLanguageListTwoLine_: function() {
+    return cr.isChromeOS || cr.isWindows ? 'two-line' : '';
   },
 
-  /**
-   * Opens the input method extension's options page in a new tab (or focuses
-   * an existing instance of the IME's options).
-   * @param {!{model: !{item: chrome.languageSettingsPrivate.InputMethod}}} e
-   * @private
-   */
-  onInputMethodOptionsTap_: function(e) {
-    assert(cr.isChromeOS);
-    this.languageHelper.openInputMethodOptions(e.model.item.id);
-  },
-
+// <if expr="not is_macosx">
   /**
    * Returns the secondary text for the spell check subsection based on the
    * enabled spell check languages, listing at most 2 languages.
    * @return {string}
    * @private
    */
   getSpellCheckSecondaryText_: function() {
     var enabledSpellCheckLanguages =
         this.languages.enabled.filter(function(languageState) {
           return languageState.spellCheckEnabled &&
@@ skipping 23 matching lines @@
             enabledSpellCheckLanguages[1].language.displayName,
             (enabledSpellCheckLanguages.length - 2).toLocaleString());
     }
   },
 
   /**
    * Opens the Custom Dictionary page.
    * @private
    */
   onEditDictionaryTap_: function() {
-    assert(!cr.isMac);
     settings.navigateTo(settings.Route.EDIT_DICTIONARY);
   },
 
   /**
-   * Checks whether the prospective UI language (the pref that indicates what
-   * language to use in Chrome) matches the current language. This pref is used
-   * only on Chrome OS and Windows; we don't control the UI language elsewhere.
-   * @param {string} languageCode The language code identifying a language.
-   * @param {string} prospectiveUILanguage The prospective UI language.
-   * @return {boolean} True if the given language matches the prospective UI
-   *     pref (which may be different from the actual UI language).
-   * @private
+   * Handler for enabling or disabling spell check.
+   * @param {!{target: Element, model: !{item: !LanguageState}}} e
    */
-  isProspectiveUILanguage_: function(languageCode, prospectiveUILanguage) {
-    assert(cr.isChromeOS || cr.isWindows);
-    return languageCode == prospectiveUILanguage;
-  },
+  onSpellCheckChange_: function(e) {
+    var item = e.model.item;
+    if (!item.language.supportsSpellcheck)
+      return;
 
-// <if expr="chromeos or is_win">
-   /**
-    * @param {string} prospectiveUILanguage
-    * @return {string}
-    * @private
-    */
-  getProspectiveUILanguageName_: function(prospectiveUILanguage) {
-    return this.languageHelper.getLanguage(prospectiveUILanguage).displayName;
-  },
-// </if>
-
-  /**
-   * @return {string}
-   * @private
-   */
-  getLanguageListTwoLine_: function() {
-    return cr.isChromeOS || cr.isWindows ? 'two-line' : '';
+    this.languageHelper.toggleSpellCheck(item.language.code,
+                                         !item.spellCheckEnabled);
   },
 
   /**
    * @return {string}
    * @private
    */
   getSpellCheckListTwoLine_: function() {
     return this.spellCheckSecondaryText_.length ? 'two-line' : '';
   },
+// </if>
 
   /**
    * Returns either the "selected" class, if the language matches the
    * prospective UI language, or an empty string. Languages can only be
    * selected on Chrome OS and Windows.
    * @param {string} languageCode The language code identifying a language.
    * @param {string} prospectiveUILanguage The prospective UI language.
    * @return {string} The class name for the language item.
    * @private
    */
   getLanguageItemClass_: function(languageCode, prospectiveUILanguage) {
     if ((cr.isChromeOS || cr.isWindows) &&
         languageCode == prospectiveUILanguage) {
       return 'selected';
     }
     return '';
   },
 
-   /**
-   * @param {string} languageCode The language code identifying a language.
-   * @param {string} prospectiveUILanguage The prospective UI language.
-   * @return {boolean} True if the prospective UI language is set to
-   *     |languageCode| but requires a restart to take effect.
-   * @private
-   */
-  isRestartRequired_: function(languageCode, prospectiveUILanguage) {
-    return prospectiveUILanguage == languageCode &&
-        this.languageHelper.requiresRestart();
-  },
-
+// <if expr="chromeos">
   /**
    * @param {string} id The input method ID.
    * @param {string} currentId The ID of the currently enabled input method.
    * @return {boolean} True if the IDs match.
    * @private
    */
   isCurrentInputMethod_: function(id, currentId) {
     assert(cr.isChromeOS);
     return id == currentId;
   },
@@ skipping 10 matching lines @@
   },
 
   getInputMethodName_: function(id) {
     assert(cr.isChromeOS);
     var inputMethod = this.languages.inputMethods.enabled.find(
         function(inputMethod) {
           return inputMethod.id == id;
         });
     return inputMethod ? inputMethod.displayName : '';
   },
+// </if>
 
   /**
    * @param {!Event} e
    * @private
    */
   onDotsTap_: function(e) {
     // Set a copy of the LanguageState object since it is not data-bound to the
     // languages model directly.
     this.detailLanguage_ = /** @type {!LanguageState} */(Object.assign(
         {},
         /** @type {!{model: !{item: !LanguageState}}} */(e).model.item));
 
     // Ensure the template has been stamped.
     var menu = /** @type {?CrActionMenuElement} */(
         this.$.menu.getIfExists());
     if (!menu) {
       menu = /** @type {!CrActionMenuElement} */(this.$.menu.get());
-      this.initializeMenu_(menu);
+// <if expr="chromeos">
+      this.tweakMenuForCrOs_(menu);
+// </if>
     }
 
     menu.showAt(/** @type {!Element} */ (e.target));
   },
 
   /**
-   * Applies Chrome OS session tweaks to the menu.
-   * @param {!CrActionMenuElement} menu
-   * @private
-   */
-  initializeMenu_: function(menu) {
-    // In a CrOS multi-user session, the primary user controls the UI language.
-    // TODO(michaelpg): The language selection should not be hidden, but should
-    // show a policy indicator. crbug.com/648498
-    if (this.isSecondaryUser_())
-      menu.querySelector('#uiLanguageItem').hidden = true;
-
-    // The UI language choice doesn't persist for guests.
-    if (cr.isChromeOS &&
-        (uiAccountTweaks.UIAccountTweaks.loggedInAsGuest() ||
-         uiAccountTweaks.UIAccountTweaks.loggedInAsPublicAccount())) {
-      menu.querySelector('#uiLanguageItem').hidden = true;
-    }
-  },
-
-  /**
    * Closes the shared action menu after a short delay, so when a checkbox is
    * tapped it can be seen to change state before disappearing.
    * @private
    */
   closeMenuSoon_: function() {
     var menu = /** @type {!CrActionMenuElement} */(this.$.menu.get());
     setTimeout(function() {
       if (menu.open)
         menu.close();
     }, settings.kMenuCloseDelay);
   },
 
+// <if expr="chromeos or is_win">
   /**
    * Handler for the restart button.
    * @private
    */
   onRestartTap_: function() {
 // <if expr="chromeos">
     settings.LifetimeBrowserProxyImpl.getInstance().signOutAndRestart();
 // </if>
-// <if expr="not chromeos">
+// <if expr="is_win">
     settings.LifetimeBrowserProxyImpl.getInstance().restart();
 // </if>
   },
+// </if>
 
   /**
    * Toggles the expand button within the element being listened to.
    * @param {!Event} e
    * @private
    */
   toggleExpandButton_: function(e) {
     // The expand button handles toggling itself.
     var expandButtonTag = 'CR-EXPAND-BUTTON';
     if (e.target.tagName == expandButtonTag)
       return;
 
     /** @type {!CrExpandButtonElement} */
     var expandButton = e.currentTarget.querySelector(expandButtonTag);
     assert(expandButton);
     expandButton.expanded = !expandButton.expanded;
   },
 });
 })();