Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2822843002: Use to_snapshot when cluster serializing LibraryPrefixes. (Closed)

Created:
3 years, 8 months ago by rmacnak
Modified:
3 years, 8 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use to_snapshot when cluster serializing LibraryPrefixes. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/0733810528e6807c42d6f827bcf267986911c935

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : ports -> imports/exports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -24 lines) Patch
M runtime/vm/clustered_snapshot.cc View 4 chunks +10 lines, -3 lines 0 comments Download
M runtime/vm/object_service.cc View 1 2 3 chunks +22 lines, -21 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
3 years, 8 months ago (2017-04-15 00:06:07 UTC) #2
siva
lgtm https://codereview.chromium.org/2822843002/diff/20001/runtime/vm/object_service.cc File runtime/vm/object_service.cc (right): https://codereview.chromium.org/2822843002/diff/20001/runtime/vm/object_service.cc#newcode529 runtime/vm/object_service.cc:529: Array& ports = Array::Handle(); Using the name ports ...
3 years, 8 months ago (2017-04-15 00:56:51 UTC) #3
rmacnak
https://codereview.chromium.org/2822843002/diff/20001/runtime/vm/object_service.cc File runtime/vm/object_service.cc (right): https://codereview.chromium.org/2822843002/diff/20001/runtime/vm/object_service.cc#newcode529 runtime/vm/object_service.cc:529: Array& ports = Array::Handle(); On 2017/04/15 00:56:51, siva wrote: ...
3 years, 8 months ago (2017-04-17 16:02:58 UTC) #4
rmacnak
3 years, 8 months ago (2017-04-17 16:04:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
0733810528e6807c42d6f827bcf267986911c935 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698