Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2822833002: [fuchsia] Use new mx_deadline_after interface (Closed)

Created:
3 years, 8 months ago by Todd Eisenberger
Modified:
3 years, 8 months ago
Reviewers:
zra, teisenbe
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[fuchsia] Use new mx_deadline_after interface BUG= R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/d42f61155fb0024bc31e12bd09506895ac21e1aa

Patch Set 1 #

Total comments: 1

Patch Set 2 : [fuchsia] Use new mx_deadline_after interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M runtime/bin/utils_fuchsia.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/os_fuchsia.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
teisenbe
3 years, 8 months ago (2017-04-17 19:02:19 UTC) #4
zra
https://codereview.chromium.org/2822833002/diff/1/runtime/vm/os_fuchsia.cc File runtime/vm/os_fuchsia.cc (right): https://codereview.chromium.org/2822833002/diff/1/runtime/vm/os_fuchsia.cc#newcode164 runtime/vm/os_fuchsia.cc:164: void OS::Sleep(int64_t millis) { This should probably just call ...
3 years, 8 months ago (2017-04-17 20:03:26 UTC) #5
teisenbe
3 years, 8 months ago (2017-04-17 20:32:11 UTC) #6
zra
lgtm
3 years, 8 months ago (2017-04-17 20:37:11 UTC) #7
teisenbe
On 2017/04/17 20:37:11, zra wrote: > lgtm Can you merge this; I don't think I ...
3 years, 8 months ago (2017-04-17 20:39:41 UTC) #8
zra
On 2017/04/17 20:39:41, teisenbe wrote: > On 2017/04/17 20:37:11, zra wrote: > > lgtm > ...
3 years, 8 months ago (2017-04-17 20:46:30 UTC) #9
zra
3 years, 8 months ago (2017-04-17 20:49:55 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
d42f61155fb0024bc31e12bd09506895ac21e1aa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698