Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 282283002: add pathops to debugger (Closed)

Created:
6 years, 7 months ago by caryclark
Modified:
6 years, 7 months ago
Reviewers:
robertphillips, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

This adds a checkbox to the debugger to allow seeing the effect pathops has on the clip. A new tab shows the C code that the pathops generate. Once in place, this CL found a bug in the pathops code where it was not handling empty clip stack elements correctly. The Cl also has the change to SkCanvas to fix this bug. Committed: http://code.google.com/p/skia/source/detail?r=14774

Patch Set 1 #

Patch Set 2 : handle empty stack elements correctly #

Patch Set 3 : show clip stack only when pathops are enabled #

Total comments: 22

Patch Set 4 : fix nits #

Patch Set 5 : make getAllowSimplifyClip const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -5 lines) Patch
M debugger/QT/SkDebuggerGUI.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 1 2 3 5 chunks +14 lines, -0 lines 0 comments Download
M debugger/QT/SkInspectorWidget.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M debugger/QT/SkInspectorWidget.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M debugger/QT/SkSettingsWidget.h View 2 chunks +6 lines, -0 lines 0 comments Download
M debugger/QT/SkSettingsWidget.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M debugger/SkDebugger.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M debugger/SkDebugger.cpp View 1 3 chunks +8 lines, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkCanvas.cpp View 1 1 chunk +3 lines, -4 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 2 3 4 5 chunks +19 lines, -0 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 2 3 3 chunks +150 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
caryclark
for amusement factor only, my independently written but nearly identical CL
6 years, 7 months ago (2014-05-15 17:16:25 UTC) #1
caryclark
Go ahead and review for real. I'm not married to any of my changes to ...
6 years, 7 months ago (2014-05-16 11:44:46 UTC) #2
robertphillips
lgtm + nits https://codereview.chromium.org/282283002/diff/40001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/282283002/diff/40001/debugger/QT/SkDebuggerGUI.cpp#newcode418 debugger/QT/SkDebuggerGUI.cpp:418: setupOverviewText(picture->typeTimes(), picture->totTime(), kNumRepeats); this-> ? https://codereview.chromium.org/282283002/diff/40001/debugger/QT/SkDebuggerGUI.cpp#newcode671 ...
6 years, 7 months ago (2014-05-16 12:21:23 UTC) #3
caryclark
https://codereview.chromium.org/282283002/diff/40001/debugger/QT/SkDebuggerGUI.cpp File debugger/QT/SkDebuggerGUI.cpp (right): https://codereview.chromium.org/282283002/diff/40001/debugger/QT/SkDebuggerGUI.cpp#newcode418 debugger/QT/SkDebuggerGUI.cpp:418: setupOverviewText(picture->typeTimes(), picture->totTime(), kNumRepeats); On 2014/05/16 12:21:24, robertphillips wrote: > ...
6 years, 7 months ago (2014-05-16 13:49:02 UTC) #4
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-05-16 13:54:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/282283002/60001
6 years, 7 months ago (2014-05-16 13:54:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 13:54:27 UTC) #7
commit-bot: I haz the power
Presubmit check for 282283002-60001 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 7 months ago (2014-05-16 13:54:28 UTC) #8
caryclark
Mike, this edits a public API. Please take a look.
6 years, 7 months ago (2014-05-16 13:56:04 UTC) #9
robertphillips
https://codereview.chromium.org/282283002/diff/40001/src/utils/debugger/SkDebugCanvas.h File src/utils/debugger/SkDebugCanvas.h (right): https://codereview.chromium.org/282283002/diff/40001/src/utils/debugger/SkDebugCanvas.h#newcode40 src/utils/debugger/SkDebugCanvas.h:40: Can this be "bool getAllowSimplifyClip() const" ?
6 years, 7 months ago (2014-05-16 13:57:40 UTC) #10
caryclark
https://codereview.chromium.org/282283002/diff/40001/src/utils/debugger/SkDebugCanvas.h File src/utils/debugger/SkDebugCanvas.h (right): https://codereview.chromium.org/282283002/diff/40001/src/utils/debugger/SkDebugCanvas.h#newcode40 src/utils/debugger/SkDebugCanvas.h:40: On 2014/05/16 13:57:41, robertphillips wrote: > Can this be ...
6 years, 7 months ago (2014-05-16 14:02:01 UTC) #11
caryclark
please review : API change
6 years, 7 months ago (2014-05-19 13:32:40 UTC) #12
reed1
lgtm
6 years, 7 months ago (2014-05-19 13:34:37 UTC) #13
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 7 months ago (2014-05-19 13:47:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/282283002/80001
6 years, 7 months ago (2014-05-19 13:47:49 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 13:53:13 UTC) #16
Message was sent while issue was closed. 
Change committed as 14774

Powered by Google App Engine
This is Rietveld 408576698