Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h

Issue 2822773002: [subresource_filter] Force the popup blocker on sites with activation (Closed)
Patch Set: Integrate with popup blocker Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
diff --git a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
index e113c3cc890bbb450240095f48ca54ec2a3e9ed7..8194844af0b938823b293bcc951605cd8d7d0de4 100644
--- a/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
+++ b/components/subresource_filter/content/browser/content_subresource_filter_throttle_manager.h
@@ -91,6 +91,10 @@ class ContentSubresourceFilterThrottleManager
content::NavigationHandle* navigation_handle,
std::vector<std::unique_ptr<content::NavigationThrottle>>* throttles);
+ // Returns whether or not the current WebContents is allowed to create a new
+ // window.
+ bool ShouldDisallowNewWindow();
+
VerifiedRuleset::Handle* ruleset_handle_for_testing() {
return ruleset_handle_.get();
}
@@ -120,8 +124,6 @@ class ContentSubresourceFilterThrottleManager
// Calls OnFirstSubresourceLoadDisallowed on the Delegate at most once per
// committed, non-same-page navigation in the main frame.
- // TODO(csharrison): Ensure IPCs from the renderer go through this path when
- // they disallow subresource loads.
void MaybeCallFirstDisallowedLoad();
VerifiedRuleset::Handle* EnsureRulesetHandle();

Powered by Google App Engine
This is Rietveld 408576698