Issue 2822743003: Preserve alpha channel of 1.0 when emulating RGB back buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2822743003: Preserve alpha channel of 1.0 when emulating RGB back buffer.

Created:
3 years, 8 months ago by Ken Russell (switch to Gerrit)

Modified:
3 years, 8 months ago

Reviewers:

CC:
chromium-reviews, krit, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jam, pdr+graphicswatchlist_chromium.org, fmalita+watch_chromium.org, blink-reviews, Rik, darin-cc_chromium.org, Justin Novosad, haraken, piman+watch_chromium.org, kinuko+watch, ajuma+watch_chromium.org, Stephen Chennney, rwlbuis

Target Ref:
refs/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Preserve alpha channel of 1.0 when emulating RGB back buffer. BlitFramebuffer from a multisampled RGBA renderbuffer to the default back buffer would overwrite the alpha channel in this case. BUG=699566 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+164 lines, -0 lines)			Patch
A	content/test/data/gpu/pixel_webgl2_blitframebuffer_noalpha.html	View	1 chunk	+78 lines, -0 lines	0 comments	Download
A	content/test/data/gpu/pixel_webgl2_util.js	View	1 chunk	+34 lines, -0 lines	0 comments	Download
M	content/test/gpu/gpu_tests/pixel_expectations.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/test/gpu/gpu_tests/pixel_test_pages.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp	View	3 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ken Russell (switch to Gerrit)

3 years, 8 months ago (2017-04-15 03:01:36 UTC) #1

Description was changed from

==========
Preserve alpha channel of 1.0 when emulating RGB back buffer.

BlitFramebuffer from a multisampled RGBA renderbuffer to the default
back buffer would overwrite the alpha channel in this case.

BUG=699566
==========

to

==========
Preserve alpha channel of 1.0 when emulating RGB back buffer.

BlitFramebuffer from a multisampled RGBA renderbuffer to the default
back buffer would overwrite the alpha channel in this case.

BUG=699566
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages