Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: tools/perf/core/perf_data_generator_unittest.py

Issue 2822723002: [Telemetry]Do not run power.idle_platform for reference build runs (Closed)
Patch Set: use telemetry benchmark class Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/core/perf_data_generator.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/perf_data_generator_unittest.py
diff --git a/tools/perf/core/perf_data_generator_unittest.py b/tools/perf/core/perf_data_generator_unittest.py
index 4aad5c30d22b13d07292ddba75268917644a75c2..4301ffa9d78a992f54a6a7650cd51684688f91b6 100644
--- a/tools/perf/core/perf_data_generator_unittest.py
+++ b/tools/perf/core/perf_data_generator_unittest.py
@@ -6,6 +6,8 @@ import unittest
from core import perf_data_generator
from core.perf_data_generator import BenchmarkMetadata
+from telemetry import benchmark
+
class PerfDataGeneratorTest(unittest.TestCase):
def setUp(self):
@@ -111,3 +113,30 @@ class PerfDataGeneratorTest(unittest.TestCase):
'isolate_name': 'telemetry_perf_tests',
}
self.assertEquals(test, expected_generated_test)
+
+ def testGenerateTelemetryTestsBlacklistedReferenceBuildTest(self):
+ class BlacklistedBenchmark(benchmark.Benchmark):
+ @classmethod
+ def Name(cls):
+ return 'blacklisted'
+
+ class NotBlacklistedBenchmark(benchmark.Benchmark):
+ @classmethod
+ def Name(cls):
+ return 'not_blacklisted'
+
+ swarming_dimensions = [
+ {'os': 'SkyNet', 'id': 'T-850', 'pool': 'T-RIP', 'device_ids': ['a']}
+ ]
+ test_config = {
+ 'platform': 'android',
+ 'swarming_dimensions': swarming_dimensions,
+ }
+ benchmarks = [BlacklistedBenchmark, NotBlacklistedBenchmark]
+ tests = perf_data_generator.generate_telemetry_tests(
+ test_config, benchmarks, None, False, ['blacklisted'])
+
+ generated_test_names = set(t['name'] for t in tests)
+ self.assertEquals(
+ generated_test_names,
+ {'blacklisted', 'not_blacklisted', 'not_blacklisted.reference'})
« no previous file with comments | « tools/perf/core/perf_data_generator.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698