Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/perf/core/perf_data_generator.py

Issue 2822723002: [Telemetry]Do not run power.idle_platform for reference build runs (Closed)
Patch Set: unittests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/core/perf_data_generator_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/core/perf_data_generator.py
diff --git a/tools/perf/core/perf_data_generator.py b/tools/perf/core/perf_data_generator.py
index 927965e257f249131a913e3d7c68c97188f99c2b..7cdba8f58a02b8bd0fdefbc66a34034ab43b3542 100755
--- a/tools/perf/core/perf_data_generator.py
+++ b/tools/perf/core/perf_data_generator.py
@@ -581,7 +581,10 @@ def generate_cplusplus_isolate_script_test(dimension):
def generate_telemetry_tests(
- tester_config, benchmarks, benchmark_sharding_map, use_whitelist):
+ tester_config, benchmarks, benchmark_sharding_map, use_whitelist,
+ benchmark_ref_build_blacklist=None):
+ if benchmark_ref_build_blacklist is None:
+ benchmark_ref_build_blacklist = BENCHMARK_REF_BUILD_BLACKLIST
nednguyen 2017/04/14 18:09:02 Sorry, I mean that we should update the caller of
rnephew (Reviews Here) 2017/04/14 18:19:37 Done.
isolated_scripts = []
# First determine the browser that you need based on the tester
browser_name = ''
@@ -624,13 +627,15 @@ def generate_telemetry_tests(
swarming_dimensions, benchmark.Name(), browser_name)
isolated_scripts.append(test)
# Now create another executable for this benchmark on the reference browser
- reference_test = generate_telemetry_test(
- swarming_dimensions, benchmark.Name(),'reference')
- isolated_scripts.append(reference_test)
- if current_shard == (num_shards - 1):
- current_shard = 0
- else:
- current_shard += 1
+ # if it is not blacklisted from running on the reference browser.
+ if benchmark.Name() not in benchmark_ref_build_blacklist:
+ reference_test = generate_telemetry_test(
+ swarming_dimensions, benchmark.Name(),'reference')
+ isolated_scripts.append(reference_test)
+ if current_shard == (num_shards - 1):
+ current_shard = 0
+ else:
+ current_shard += 1
return isolated_scripts
@@ -668,6 +673,12 @@ LEGACY_DEVICE_AFFIINITY_ALGORITHM = [
'Win 10 High-DPI Perf',
]
+# List of benchmarks that are to never be run with reference builds.
+BENCHMARK_REF_BUILD_BLACKLIST = [
+ 'power.idle_platform',
+]
+
+
def current_benchmarks(use_whitelist):
benchmarks_dir = os.path.join(src_dir(), 'tools', 'perf', 'benchmarks')
top_level_dir = os.path.dirname(benchmarks_dir)
« no previous file with comments | « tools/perf/benchmark.csv ('k') | tools/perf/core/perf_data_generator_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698