[Telemetry]Do not run power.idle_platform for reference build runs

tools/perf/core/perf_data_generator_unittest.py

 # Copyright 2017 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import unittest
 
 from core import perf_data_generator
 from core.perf_data_generator import BenchmarkMetadata
 
 
+class _MockBenchmark(object):

[nednguyen, 2017/04/14 20:45:59]

why not just inherits this from the real benchmark.Benchmark?

[rnephew (Reviews Here), 2017/04/14 21:40:17]

My intention was to not create unnecessary dependencies on catapult.

+  def __init__(self, name):
+   self.name = name
+
+  def Name(self):
+    return self.name
+
+
 class PerfDataGeneratorTest(unittest.TestCase):
   def setUp(self):
     # Test config can be big, so set maxDiff to None to see the full comparision
     # diff when assertEquals fails.
     self.maxDiff = None
 
   def testVerifyAllTestsInBenchmarkCsvPassesWithCorrectInput(self):
     tests = {
         'AAAAA1 AUTOGENERATED': {},
         'Android Nexus5 Perf (2)': {
@@ skipping 84 matching lines @@
           'dimension_sets': [{'os': 'SkyNet', 'id': 'T-850', 'pool': 'T-RIP'}],
           'hard_timeout': 7200,
           'can_use_on_swarming_builders': True,
           'expiration': 36000,
           'io_timeout': 3600,
         },
         'name': 'speedometer.reference',
         'isolate_name': 'telemetry_perf_tests',
       }
     self.assertEquals(test, expected_generated_test)
+
+  def testGenerateTelemetryTestsBlacklistedReferenceBuildTest(self):
+    swarming_dimensions = [
+        {'os': 'SkyNet', 'id': 'T-850', 'pool': 'T-RIP', 'device_ids': ['a']}
+    ]
+    test_config = {
+        'platform': 'android',
+        'swarming_dimensions': swarming_dimensions,
+    }
+    benchmarks = [
+        _MockBenchmark('blacklisted'),
+        _MockBenchmark('not_blacklisted')
+    ]
+    tests = perf_data_generator.generate_telemetry_tests(
+        test_config, benchmarks, None, False, ['blacklisted'])
+    expected_generated_tests = [

[nednguyen, 2017/04/14 20:45:59]

I think we only need a a few test methods that test the generated data. For this
one, you just need to test that there are 3 tests get generated:

generated_test_names = set(t.name for t in tests)
self.assertEquals(generated_test_names, {'blacklisted', 'not_blacklisted', 
'not_blacklisted'})

[rnephew (Reviews Here), 2017/04/14 21:40:17]

Done.

+        {'args': ['blacklisted',
+                  '-v',
+                  '--upload-results',
+                  '--output-format=chartjson',
+                  '--browser=android-chromium'],
+         'isolate_name': 'telemetry_perf_tests',
+         'name': 'blacklisted',
+         'override_compile_targets': ['telemetry_perf_tests'],
+         'swarming': {'can_use_on_swarming_builders': True,
+                      'dimension_sets': [{'id': 'a',
+                                          'os': 'SkyNet',
+                                          'pool': 'Chrome-perf'}],
+                      'expiration': 36000,
+                      'hard_timeout': 7200,
+                      'ignore_task_failure': False,
+                      'io_timeout': 3600}},
+        {'args': ['not_blacklisted',
+                  '-v',
+                  '--upload-results',
+                  '--output-format=chartjson',
+                  '--browser=android-chromium'],
+         'isolate_name': 'telemetry_perf_tests',
+         'name': 'not_blacklisted',
+         'override_compile_targets': ['telemetry_perf_tests'],
+         'swarming': {'can_use_on_swarming_builders': True,
+                      'dimension_sets': [{'id': 'a',
+                                          'os': 'SkyNet',
+                                          'pool': 'Chrome-perf'}],
+                      'expiration': 36000,
+                      'hard_timeout': 7200,
+                      'ignore_task_failure': False,
+                      'io_timeout': 3600}},
+        {'args': ['not_blacklisted',
+                  '-v',
+                  '--upload-results',
+                  '--output-format=chartjson',
+                  '--browser=reference',
+                  '--output-trace-tag=_ref'],
+         'isolate_name': 'telemetry_perf_tests',
+         'name': 'not_blacklisted.reference',
+         'override_compile_targets': ['telemetry_perf_tests'],
+         'swarming': {'can_use_on_swarming_builders': True,
+                      'dimension_sets': [{'id': 'a',
+                                          'os': 'SkyNet',
+                                          'pool': 'Chrome-perf'}],
+                         'expiration': 36000,
+                         'hard_timeout': 7200,
+                         'ignore_task_failure': True,
+                         'io_timeout': 3600}
+        }
+    ]
+    self.assertEquals(tests, expected_generated_tests)