Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 28227: Add ToUpperASCII and StringToUpperASCII. (Closed)

Created:
11 years, 10 months ago by wtc
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Add ToUpperASCII and StringToUpperASCII. R=darin,eroman Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10576

Patch Set 1 #

Patch Set 2 : Use 2 instead of 1 in unit test to avoid confusion with small ell #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -2 lines) Patch
M base/string_util.h View 3 chunks +23 lines, -2 lines 0 comments Download
M base/string_util_unittest.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wtc
darin: just a question: ToUpperASCII is only used by the LM_Hash function. By default we ...
11 years, 10 months ago (2009-02-26 23:13:13 UTC) #1
darin (slow to review)
LGTM. I think this is a good addition to string_util.h. Perhaps it would be best ...
11 years, 10 months ago (2009-02-26 23:31:12 UTC) #2
eroman
11 years, 10 months ago (2009-02-27 00:34:14 UTC) #3 
LGTM

Powered by Google App Engine
This is Rietveld 408576698