Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(591)

Issue 2822633003: fix #29346, ensure all nodes are implemented by DDC's code generator (Closed)

Created:
3 years, 8 months ago by Jennifer Messerly
Modified:
3 years, 8 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #29346, ensure all nodes are implemented by DDC's code generator R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/b76e2d67cf9a0462d1d8ba6d3c2c23554730a754

Patch Set 1 #

Patch Set 2 : fix long line #

Patch Set 3 : fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -95 lines) Patch
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 2 35 chunks +239 lines, -70 lines 2 comments Download
M pkg/dev_compiler/lib/src/js_ast/nodes.dart View 1 2 1 chunk +18 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/src/js_ast/printer.dart View 1 2 1 chunk +7 lines, -8 lines 0 comments Download
M pkg/dev_compiler/lib/src/js_ast/template.dart View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/dev_compiler/test/codegen_expected/map_keys.js.map View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/dev_compiler/test/codegen_expected/sunflower/sunflower.js.map View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Jennifer Messerly
3 years, 8 months ago (2017-04-14 05:35:24 UTC) #2
vsm
lgtm! https://codereview.chromium.org/2822633003/diff/20001/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2822633003/diff/20001/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode3828 pkg/dev_compiler/lib/src/compiler/code_generator.dart:3828: assert(false); Should this just be in your unreachable ...
3 years, 8 months ago (2017-04-14 13:14:39 UTC) #3
Jennifer Messerly
thanks!!! https://codereview.chromium.org/2822633003/diff/20001/pkg/dev_compiler/lib/src/compiler/code_generator.dart File pkg/dev_compiler/lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/2822633003/diff/20001/pkg/dev_compiler/lib/src/compiler/code_generator.dart#newcode3828 pkg/dev_compiler/lib/src/compiler/code_generator.dart:3828: assert(false); On 2017/04/14 13:14:39, vsm wrote: > Should ...
3 years, 8 months ago (2017-04-14 17:03:58 UTC) #4
Jennifer Messerly
3 years, 8 months ago (2017-04-14 17:11:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
b76e2d67cf9a0462d1d8ba6d3c2c23554730a754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698