Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 282263008: Retry: Stop ServiceWorker context when no controllee is associated (Closed)

Created:
6 years, 7 months ago by kinuko
Modified:
6 years, 7 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Visibility:
Public.

Description

Retry: Stop ServiceWorker context when no controllee is associated Re-landing https://codereview.chromium.org/272183005 with leak fix. BUG=372673 TBR=michaeln@chromium.org,horo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271004

Patch Set 1 : #

Patch Set 2 : leak fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -15 lines) Patch
M content/browser/service_worker/embedded_worker_instance.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 4 chunks +16 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 4 chunks +5 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 9 chunks +27 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinuko
Re-landing https://codereview.chromium.org/272183005 with a leak fix (diff between PS1 and PS2). Looks like there has ...
6 years, 7 months ago (2014-05-16 11:19:24 UTC) #1
kinuko
The CQ bit was checked by kinuko@chromium.org
6 years, 7 months ago (2014-05-16 11:20:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/282263008/40001
6 years, 7 months ago (2014-05-16 11:21:15 UTC) #3
horo
6 years, 7 months ago (2014-05-16 12:24:14 UTC) #4
horo
lgtm
6 years, 7 months ago (2014-05-16 12:24:16 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 13:18:15 UTC) #6
Message was sent while issue was closed.
Change committed as 271004

Powered by Google App Engine
This is Rietveld 408576698