Source/bindings/scripts/v8_attributes.py - Issue 282263007: Fix bindings when using [CachedAttribute] on Array.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_attributes.py

Issue 282263007: Fix bindings when using [CachedAttribute] on Array. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@language_change_tests

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/scripts/v8_attributes.py

diff --git a/Source/bindings/scripts/v8_attributes.py b/Source/bindings/scripts/v8_attributes.py

index 1ce5249e5bd9ea99de51e6059a3aa3fe4b4ef563..008a512f3ed2ccf08a92be12de0733494268e35f 100644

--- a/Source/bindings/scripts/v8_attributes.py

+++ b/Source/bindings/scripts/v8_attributes.py

@@ -201,6 +201,8 @@ def generate_getter(interface, attribute, contents):

contents.update({

'cpp_value': cpp_value,

+ # We need to override cpp_value_to_v8_value to make sure the cpp_value being used is in sync.

haraken 2014/05/16 11:06:22 I'd remove this comment.

+ 'cpp_value_to_v8_value': idl_type.cpp_value_to_v8_value(cpp_value=cpp_value, creation_context='info.Holder()'),

'v8_set_return_value_for_main_world': v8_set_return_value_statement(for_main_world=True),

'v8_set_return_value': v8_set_return_value_statement(),

})

« no previous file with comments | « no previous file | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »