Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 282263006: Oilpan: remove consts when checking GC-class convertibility. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: remove consts when checking GC-class convertibility. Achieve the desired conversion outcomes when working with const types, explicitly removing "const" qualifiers throughout before testing if class types can be converted to GarbageCollected{Mixin,Finalized} etc. R=haraken@chromium.org,erik.corry@gmail.com BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Source/platform/heap/Handle.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/platform/heap/ThreadState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/heap/Visitor.h View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
haraken
This makes sense to me, but template experts in Denmark should take a look :)
6 years, 7 months ago (2014-05-16 08:18:44 UTC) #1
sof
On 2014/05/16 08:18:44, haraken wrote: > This makes sense to me, but template experts in ...
6 years, 7 months ago (2014-05-16 08:23:50 UTC) #2
sof
Please take a look.
6 years, 7 months ago (2014-05-16 08:24:14 UTC) #3
Erik Corry
LGTM It's Store Bededag i Denmark today, so code review responses won't be very fast.
6 years, 7 months ago (2014-05-16 11:38:03 UTC) #4
sof
On 2014/05/16 11:38:03, Erik Corry wrote: > LGTM > > It's Store Bededag i Denmark ...
6 years, 7 months ago (2014-05-16 11:51:04 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-16 11:51:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/282263006/1
6 years, 7 months ago (2014-05-16 11:51:39 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 13:07:51 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 14:06:39 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/6891)
6 years, 7 months ago (2014-05-16 14:06:39 UTC) #10
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-16 14:38:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/282263006/1
6 years, 7 months ago (2014-05-16 14:38:47 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-16 15:15:27 UTC) #13
Message was sent while issue was closed.
Change committed as 174175

Powered by Google App Engine
This is Rietveld 408576698