Issue 282263003: TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadS…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 282263003: TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadS… (Closed)

Created:
6 years, 7 months ago by ernstm

Modified:
6 years, 7 months ago

Reviewers:
Lei Zhang, Alexander Potapenko

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

TSANv2: Remove race suppression in cc::RenderingStatsInstrumentation::AccumulateAndClearImplThreadStats. Race is fixed. R=thestig@chromium.org,glider@chromium.org NOTRY=True BUG=370244 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270817

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	tools/valgrind/tsan_v2/suppressions.txt	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 6 (0 generated)

Alexander Potapenko

On 2014/05/15 17:46:39, ernstm wrote: > PTAL LGTM

6 years, 7 months ago (2014-05-15 17:57:12 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/282263003/1

6 years, 7 months ago (2014-05-15 18:05:34 UTC) #4

Alexander Potapenko

You could probably set NOTRY=true, as CQ doesn't test TSan v2 suppressions. On Thu, May ...

6 years, 7 months ago (2014-05-15 18:21:34 UTC) #5

Message was sent while issue was closed.

Change committed as 270817