services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc - Issue 2822593002: [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

Issue 2822593002: [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (Closed)

Patch Set: Fixing the return type (adding the missing ref) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h ('k') | services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

diff --git a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

index 7bb49b68f428f66c9e136463fe19909854c6bcbb..fcf7e6e45c54d8112a269331a3eb2566cf241807 100644

--- a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

+++ b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

@@ -5,6 +5,7 @@

#include "services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h"

#include "base/trace_event/memory_dump_request_args.h"

+#include "mojo/common/common_custom_types_struct_traits.h"

#include "services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom.h"

namespace mojo {

@@ -135,6 +136,8 @@ bool StructTraits<

return false;

if (!input.ReadOsDump(&out->os_dump))

return false;

+ if (!input.ReadExtraProcessesDump(&out->extra_processes_dump))

+ return false;

return true;

}