services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom - Issue 2822593002: [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

Issue 2822593002: [Memory UMA] Return the extra_processes_dump map as part of the ResponseCallback (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/common/test_common_custom_types.mojom ('K') | « services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

diff --git a/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

index 12244c62ba2215a2416e2f32dd6cbb4374d5ae19..80978bc861e3bfabc095f62d979872cd2e5c30d7 100644

--- a/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

+++ b/services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom

@@ -4,6 +4,8 @@

module memory_instrumentation.mojom;

+import "mojo/common/process_id.mojom";

enum DumpType {

PERIODIC_INTERVAL,

EXPLICITLY_TRIGGERED,

@@ -36,7 +38,8 @@ struct ChromeMemDump {

struct MemoryDumpCallbackResult {

OSMemDump os_dump;

ChromeMemDump chrome_dump;

-};

+ map<mojo.common.mojom.ProcessId, OSMemDump> extra_processes_dump;

+};

// There should be at most one implementation of this interface per process.

interface ProcessLocalDumpManager {