telemetry/telemetry/core/android_action_runner.py - Issue 2822573002: Fix android_action_runner.InputSwipe and InputText

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/core/android_action_runner.py

Issue 2822573002: Fix android_action_runner.InputSwipe and InputText (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/core/android_action_runner.py

diff --git a/telemetry/telemetry/core/android_action_runner.py b/telemetry/telemetry/core/android_action_runner.py

index 07fdccb71d5f7fbd24fe7cd08058013f44569ac5..6f4848d0d15011ecc72a05d37f036cd45343e032 100644

--- a/telemetry/telemetry/core/android_action_runner.py

+++ b/telemetry/telemetry/core/android_action_runner.py

@@ -105,7 +105,7 @@ class AndroidActionRunner(object):

duration: The length of time of the swipe in milliseconds

"""

cmd = ['input', 'swipe']

- cmd.expand(str(x) for x in (left_start_coord, top_start_coord,

+ cmd.extend(str(x) for x in (left_start_coord, top_start_coord,

left_end_coord, top_end_coord, duration))

self._platform_backend.device.RunShellCommand(cmd, check_return=True)

« no previous file with comments | « devil/devil/android/device_utils_test.py ('k') | no next file » | no next file with comments »