gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc - Issue 282253002: Remove unneeded shm versions of bucket functions from command buffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc

Issue 282253002: Remove unneeded shm versions of bucket functions from command buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-shm-for-immediate-commands

Patch Set: rebase (1 new added hunk) Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/build_gles2_cmd_buffer.py ('K') | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_1_autogen.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc

diff --git a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc

index de52efe090264ada2ab7e5a3c0e3191f3a5f1021..221aa332a488993bc3a2a40030563a4a49b1aef7 100644

--- a/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc

+++ b/gpu/command_buffer/service/gles2_cmd_decoder_unittest_2.cc

@@ -472,25 +472,6 @@ void GLES2DecoderTestBase::SpecializedSetup<cmds::UniformMatrix4fvImmediate, 0>(

};

template <>

-void GLES2DecoderTestBase::SpecializedSetup<cmds::RenderbufferStorage, 0>(

- bool valid) {

- DoBindRenderbuffer(GL_RENDERBUFFER, client_renderbuffer_id_,

- kServiceRenderbufferId);

- if (valid) {

- EXPECT_CALL(*gl_, GetError())

- .WillOnce(Return(GL_NO_ERROR))

- .RetiresOnSaturation();

- EXPECT_CALL(*gl_,

- RenderbufferStorageEXT(GL_RENDERBUFFER, _, 3, 4))

- .Times(1)

- .RetiresOnSaturation();

- EXPECT_CALL(*gl_, GetError())

- .WillOnce(Return(GL_NO_ERROR))

- .RetiresOnSaturation();

- }

-};

-template <>

void GLES2DecoderTestBase::SpecializedSetup<cmds::TexParameterf, 0>(

bool /* valid */) {

DoBindTexture(GL_TEXTURE_2D, client_texture_id_, kServiceTextureId);