Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: gpu/command_buffer/client/gles2_cmd_helper.h

Issue 282253002: Remove unneeded shm versions of bucket functions from command buffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@no-shm-for-immediate-commands
Patch Set: rebase (1 new added hunk) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/client/gles2_cmd_helper.h
diff --git a/gpu/command_buffer/client/gles2_cmd_helper.h b/gpu/command_buffer/client/gles2_cmd_helper.h
index 4e57ccee6598ac6efdc198181950446d4e101c13..0726fbb4d4c3e3dc8bb91bde8d7c11527741c206 100644
--- a/gpu/command_buffer/client/gles2_cmd_helper.h
+++ b/gpu/command_buffer/client/gles2_cmd_helper.h
@@ -25,46 +25,21 @@ class GPU_EXPORT GLES2CmdHelper : public CommandBufferHelper {
// Helpers that could not be auto-generated.
// TODO(gman): Auto generate these.
-
void GetAttribLocation(
- GLuint program, uint32 name_shm_id, uint32 name_shm_offset,
- uint32 location_shm_id, uint32 location_shm_offset, uint32 data_size) {
- gles2::cmds::GetAttribLocation* c =
- GetCmdSpace<gles2::cmds::GetAttribLocation>();
- if (c) {
- c->Init(
- program, name_shm_id, name_shm_offset, location_shm_id,
- location_shm_offset, data_size);
- }
- }
-
- void GetAttribLocationBucket(
GLuint program, uint32 name_bucket_id,
uint32 location_shm_id, uint32 location_shm_offset) {
- gles2::cmds::GetAttribLocationBucket* c =
- GetCmdSpace<gles2::cmds::GetAttribLocationBucket>();
+ gles2::cmds::GetAttribLocation* c =
+ GetCmdSpace<gles2::cmds::GetAttribLocation>();
if (c) {
c->Init(program, name_bucket_id, location_shm_id, location_shm_offset);
}
}
void GetUniformLocation(
- GLuint program, uint32 name_shm_id, uint32 name_shm_offset,
- uint32 location_shm_id, uint32 location_shm_offset, uint32 data_size) {
- gles2::cmds::GetUniformLocation* c =
- GetCmdSpace<gles2::cmds::GetUniformLocation>();
- if (c) {
- c->Init(
- program, name_shm_id, name_shm_offset, location_shm_id,
- location_shm_offset, data_size);
- }
- }
-
- void GetUniformLocationBucket(
GLuint program, uint32 name_bucket_id,
uint32 location_shm_id, uint32 location_shm_offset) {
- gles2::cmds::GetUniformLocationBucket* c =
- GetCmdSpace<gles2::cmds::GetUniformLocationBucket>();
+ gles2::cmds::GetUniformLocation* c =
+ GetCmdSpace<gles2::cmds::GetUniformLocation>();
if (c) {
c->Init(program, name_bucket_id, location_shm_id, location_shm_offset);
}

Powered by Google App Engine
This is Rietveld 408576698