tools/metrics/histograms/histograms.xml - Issue 2822503002: leveldb::MojoEnv should not inherit from ChromiumEnv.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 2822503002: leveldb::MojoEnv should not inherit from ChromiumEnv. (Closed)

Patch Set: don't have environment name Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index c867b90c99b1397d92be28ec3d1e64489fa3d7b9..80cc97acfdd1ab99192524f8d24d49b639840cf3 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -119798,7 +119798,6 @@ from previous Chrome versions.

label="ChromiumWritableFile::SyncParent"/>

<affected-histogram name="LevelDBEnv.IDB.IOError.BFE"/>

<affected-histogram name="LevelDBEnv.IOError.BFE"/>

- <affected-histogram name="LevelDBEnv.LocalStorage.IOError.BFE"/>

<affected-histogram name="LevelDBEnv.ServiceWorker.IOError.BFE"/>

<affected-histogram name="WebCore.IndexedDB.LevelDBOpenErrors.BFE"/>

<affected-histogram name="WebCore.IndexedDB.LevelDBReadErrors.BFE"/>

@@ -119826,7 +119825,6 @@ from previous Chrome versions.

label="This histogram shows the limit when open failed for reasons

other than exceeding the limit."/>

<affected-histogram name="LevelDBEnv.IDB.MaxFDs"/>

- <affected-histogram name="LevelDBEnv.LocalStorage.MaxFDs"/>

<affected-histogram name="LevelDBEnv.MaxFDs"/>

<affected-histogram name="LevelDBEnv.ServiceWorker.MaxFDs"/>

</histogram_suffixes>

@@ -119848,8 +119846,6 @@ from previous Chrome versions.

<affected-histogram name="LevelDBEnv.IDB.RetryRecoveredFromErrorIn"/>

<affected-histogram name="LevelDBEnv.IDB.TimeUntilSuccessFor"/>

- <affected-histogram name="LevelDBEnv.LocalStorage.RetryRecoveredFromErrorIn"/>

- <affected-histogram name="LevelDBEnv.LocalStorage.TimeUntilSuccessFor"/>

Ilya Sherman 2017/04/13 21:03:03 Should these histograms be marked as <obsolete> in

<affected-histogram name="LevelDBEnv.RetryRecoveredFromErrorIn"/>

<affected-histogram

name="LevelDBEnv.ServiceWorker.RetryRecoveredFromErrorIn"/>

@@ -119869,8 +119865,6 @@ from previous Chrome versions.

<histogram_suffixes name="LevelDBEnvTypes" separator="." ordering="prefix">

- <suffix name="LocalStorage"

- label="Restricted to LocalStorage LevelDB environments"/>

Ilya Sherman 2017/04/13 21:03:03 Please mark this suffix as obsolete rather than re

<suffix name="ServiceWorker"

label="Restricted to ServiceWorker LevelDB environments"/>

<affected-histogram name="LevelDBEnv.IOError"/>

« no previous file with comments | « content/browser/dom_storage/local_storage_context_mojo.cc ('k') | no next file » | no next file with comments »