Wrap large IndexedDB values into Blobs before writing to LevelDB.

third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp

Index: third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
index 0b9f5c880a9b29684c7c84ab984c92cfa426f63d..d0d166935a0c1519484f83132c75546f159e2992 100644
--- a/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
+++ b/third_party/WebKit/Source/modules/indexeddb/IDBValue.cpp
@@ -60,6 +60,13 @@ IDBValue::IDBValue(const IDBValue* value,
   }
 }
 
+IDBValue::IDBValue(PassRefPtr<SharedBuffer> unwrapped_data,
+                   std::unique_ptr<Vector<RefPtr<BlobDataHandle>>> blob_data,
+                   std::unique_ptr<Vector<WebBlobInfo>> blob_info)
+    : data_(std::move(unwrapped_data)),
+      blob_data_(std::move(blob_data)),
+      blob_info_(std::move(blob_info)) {}
+
 IDBValue::~IDBValue() {
   if (isolate_)
     isolate_->AdjustAmountOfExternalAllocatedMemory(-external_allocated_size_);
@@ -80,6 +87,14 @@ PassRefPtr<IDBValue> IDBValue::Create(const IDBValue* value,
   return AdoptRef(new IDBValue(value, primary_key, key_path));
 }
 
+PassRefPtr<IDBValue> IDBValue::Create(
+    PassRefPtr<SharedBuffer> unwrapped_data,
+    std::unique_ptr<Vector<RefPtr<BlobDataHandle>>> blob_data,

[dcheng, 2017/05/25 18:34:04]

No need to fix in this CL, but:
1. Isn't Vector movable? It looks a bit odd to wrap it in a unique_ptr.
2. I think we're trying to get rid of PassRefPtr and just use RefPtr.

[pwnall, 2017/05/25 20:01:10]

Acknowledged.

I will look to fix both of these in a follow-up. Regarding the 2nd issue... I
tried to minimize introducing new PassRefPtrs, subject to the constraint that I
didn't want to change IDBValue. I would like to do that in a follow-up, and
remove the mental overhead of having to learn/remember how PassRefPtr works.

+    std::unique_ptr<Vector<WebBlobInfo>> blob_info) {
+  return AdoptRef(new IDBValue(std::move(unwrapped_data), std::move(blob_data),
+                               std::move(blob_info)));
+}
+
 Vector<String> IDBValue::GetUUIDs() const {
   Vector<String> uuids;
   uuids.ReserveCapacity(blob_info_->size());