Wrap large IndexedDB values into Blobs before writing to LevelDB.

third_party/WebKit/Source/modules/indexeddb/IDBRequestLoader.cpp

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "modules/indexeddb/IDBRequestLoader.h"
+
+#include "core/dom/DOMException.h"
+#include "core/fileapi/FileReaderLoader.h"
+#include "modules/indexeddb/IDBRequest.h"
+#include "modules/indexeddb/IDBRequestQueueItem.h"
+#include "modules/indexeddb/IDBValue.h"
+#include "modules/indexeddb/IDBValueWrapping.h"
+#include "public/platform/modules/indexeddb/WebIDBDatabaseException.h"
+
+namespace blink {
+
+IDBRequestLoader::IDBRequestLoader(IDBRequestQueueItem* queue_item,
+                                   Vector<RefPtr<IDBValue>>* result_values)
+    : queue_item_(queue_item), values_(result_values) {
+  DCHECK(IDBRequestLoader::NeedUnwrapping(*values_));
+  loader_ = FileReaderLoader::Create(FileReaderLoader::kReadByClient, this);
+}
+
+IDBRequestLoader::~IDBRequestLoader() {
+  // TODO(pwnall): Do we need to call loader_->Cancel() here?
+}
+
+bool IDBRequestLoader::NeedsUnwrapping(IDBValue* value) {
+  return IDBValueUnwrapper::IsWrapped(value);
+}
+
+bool IDBRequestLoader::NeedUnwrapping(const Vector<RefPtr<IDBValue>>& values) {
+  for (const auto& value : values) {
+    if (IDBValueUnwrapper::IsWrapped(value.Get()))
+      return true;
+  }
+  return false;
+}
+
+void IDBRequestLoader::Start() {
+  current_value_ = values_->begin();
+  StartNextValue();
+}
+
+void IDBRequestLoader::StartNextValue() {
+  IDBValueUnwrapper unwrapper;
+
+  while (true) {
+    if (current_value_ == values_->end()) {
+      ReportSuccess();
+      return;
+    }
+    if (unwrapper.Parse(current_value_->Get()))
+      break;
+    ++current_value_;
+  }
+
+  DCHECK(current_value_ != values_->end());
+
+  ExecutionContext* context = queue_item_->Request()->GetExecutionContext();
+  if (!context) {
+    ReportError();
+    return;
+  }
+
+  wrapped_data_.ReserveCapacity(unwrapper.WrapperBlobSize());
+  loader_->Start(context, unwrapper.WrapperBlobHandle());
+}
+
+void IDBRequestLoader::DidStartLoading() {}
+
+void IDBRequestLoader::DidReceiveDataForClient(const char* data,
+                                               unsigned data_length) {
+  DCHECK_LE(wrapped_data_.size() + data_length, wrapped_data_.capacity())
+      << "The reader returned more data than we were prepared for";

[jsbell, 2017/05/15 23:37:38]

nit: maybe log expected/actual ?

[pwnall, 2017/05/19 18:27:34]

AFAIK the DCHECK_xx variants log their arguments. Example:

STDERR: [1:1:0515/193007.830163:1049509374697:FATAL:IDBRequestLoader.cpp(74)]
Check failed: wrapped_data_.size() + data_length + 100000 <=
wrapped_data_.capacity() (165536 vs. 147424)The reader returned more data than
we were prepared for

Is this what you were looking for, or should I log something else?

[jsbell, 2017/05/22 21:54:19]

That's fine.

+
+  wrapped_data_.Append(data, data_length);
+}
+
+void IDBRequestLoader::DidFinishLoading() {
+  *current_value_ = IDBValueUnwrapper::CreateUnwrapped(
+      current_value_->Get(), SharedBuffer::AdoptVector(wrapped_data_));
+  ++current_value_;
+
+  StartNextValue();
+}
+
+void IDBRequestLoader::DidFail(FileError::ErrorCode) {
+  ReportError();
+}
+
+void IDBRequestLoader::ReportSuccess() {
+  queue_item_->MarkReady();
+}
+
+void IDBRequestLoader::ReportError() {
+  queue_item_->MarkReady(
+      DOMException::Create(kDataError, "Failed to read large IndexedDB value"));
+}
+
+}  // namespace blink