Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.h

Issue 2822433003: Cleanup Tool WebUI: Add functionality to the Scan button (Closed)
Patch Set: Add WeakPtrFactory Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.h
diff --git a/chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.h b/chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.h
index 87ee24a3f401c0a0845a488fac7e22ad44326361..894fc45cf86bd545309ff9c8a47067aa1debbf75 100644
--- a/chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.h
+++ b/chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.h
@@ -7,6 +7,8 @@
#include "base/callback.h"
#include "base/macros.h"
+#include "base/memory/weak_ptr.h"
+#include "components/component_updater/component_updater_service.h"
#include "content/public/browser/web_ui_message_handler.h"
// The handler for Javascript messages related to the "Chrome Cleanup" view.
@@ -19,7 +21,18 @@ class CleanupActionHandler : public content::WebUIMessageHandler {
void RegisterMessages() override;
private:
+ // Invalidates the weak pointers in callbacks that are no longer safe to run.
+ void OnJavascriptDisallowed() override;
+
void HandleRequestLastScanResult(const base::ListValue* args);
+ void HandleStartScan(const base::ListValue* args);
+
+ // Returns the scan result initiated by HandleStartScan() to the Javascript
+ // caller refererenced by |callback_id|.
+ void ReportScanResults(const std::string& callback_id);
+
+ // Used to cancel callbacks when JavaScript becomes disallowed.
+ base::WeakPtrFactory<CleanupActionHandler> callback_weak_ptr_factory_;
DISALLOW_COPY_AND_ASSIGN(CleanupActionHandler);
};
« no previous file with comments | « chrome/browser/resources/cleanup_tool/manager.js ('k') | chrome/browser/ui/webui/cleanup_tool/cleanup_action_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698