Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Side by Side Diff: third_party/WebKit/Source/web/InspectorOverlay.cpp

Issue 2822423002: Remove unneeded InspectorOverlay::ScheduleUpdate CHECK (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 385 matching lines...) Expand 10 before | Expand all | Expand 10 after
396 396
397 void InspectorOverlay::ScheduleUpdate() { 397 void InspectorOverlay::ScheduleUpdate() {
398 if (IsEmpty()) { 398 if (IsEmpty()) {
399 if (page_overlay_) 399 if (page_overlay_)
400 page_overlay_.reset(); 400 page_overlay_.reset();
401 return; 401 return;
402 } 402 }
403 needs_update_ = true; 403 needs_update_ = true;
404 LocalFrame* frame = frame_impl_->GetFrame(); 404 LocalFrame* frame = frame_impl_->GetFrame();
405 if (frame) { 405 if (frame) {
406 // TODO(joelhockey): Remove this check once all tests pass.
407 CHECK(frame_impl_->GetFrameView());
408 frame->GetPage()->GetChromeClient().ScheduleAnimation(frame); 406 frame->GetPage()->GetChromeClient().ScheduleAnimation(frame);
409 } 407 }
410 } 408 }
411 409
412 void InspectorOverlay::RebuildOverlayPage() { 410 void InspectorOverlay::RebuildOverlayPage() {
413 FrameView* view = frame_impl_->GetFrameView(); 411 FrameView* view = frame_impl_->GetFrameView();
414 LocalFrame* frame = frame_impl_->GetFrame(); 412 LocalFrame* frame = frame_impl_->GetFrame();
415 if (!view || !frame) 413 if (!view || !frame)
416 return; 414 return;
417 415
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
820 bool InspectorOverlay::ShouldSearchForNode() { 818 bool InspectorOverlay::ShouldSearchForNode() {
821 return inspect_mode_ != InspectorDOMAgent::kNotSearching; 819 return inspect_mode_ != InspectorDOMAgent::kNotSearching;
822 } 820 }
823 821
824 void InspectorOverlay::Inspect(Node* node) { 822 void InspectorOverlay::Inspect(Node* node) {
825 if (dom_agent_) 823 if (dom_agent_)
826 dom_agent_->Inspect(node); 824 dom_agent_->Inspect(node);
827 } 825 }
828 826
829 } // namespace blink 827 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698