Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: components/translate/core/browser/mock_translate_driver.h

Issue 2822383002: check network connectivity in onPageTranslated callback. (Closed)
Patch Set: add unit tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/translate/core/browser/mock_translate_driver.h
diff --git a/components/translate/core/browser/mock_translate_driver.h b/components/translate/core/browser/mock_translate_driver.h
index c5a7c07c36f66113ffffc2d9517aaf5b08b3d911..3164bdb6325501107b7f69cf249982cdbca658be 100644
--- a/components/translate/core/browser/mock_translate_driver.h
+++ b/components/translate/core/browser/mock_translate_driver.h
@@ -34,7 +34,7 @@ class MockTranslateDriver : public TranslateDriver {
void TranslatePage(int page_seq_no,
const std::string& translate_script,
const std::string& source_lang,
- const std::string& target_lang) override {}
+ const std::string& target_lang) override;
void RevertTranslation(int page_seq_no) override {}
@@ -58,9 +58,12 @@ class MockTranslateDriver : public TranslateDriver {
return on_translate_enabled_changed_called_;
}
+ bool TranslatePage_is_called() const { return translate_page_is_called_; }
+
private:
bool on_is_page_translated_changed_called_;
bool on_translate_enabled_changed_called_;
+ bool translate_page_is_called_;
LanguageState language_state_;
DISALLOW_COPY_AND_ASSIGN(MockTranslateDriver);

Powered by Google App Engine
This is Rietveld 408576698