Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 282233003: Factor out DumpRecord method from dump_record tool for later use (Closed)

Created:
6 years, 7 months ago by hal.canary
Modified:
6 years, 7 months ago
Reviewers:
mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Factor out DumpRecord method from dump_record tool for later use Committed: http://code.google.com/p/skia/source/detail?r=14751

Patch Set 1 #

Total comments: 8

Patch Set 2 : AnotherPatchSet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -90 lines) Patch
M gyp/tools.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A tools/DumpRecord.h View 1 1 chunk +24 lines, -0 lines 0 comments Download
A tools/DumpRecord.cpp View 1 1 chunk +113 lines, -0 lines 0 comments Download
M tools/dump_record.cpp View 1 1 chunk +7 lines, -90 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hal.canary
ptal
6 years, 7 months ago (2014-05-15 15:07:15 UTC) #1
mtklein
https://codereview.chromium.org/282233003/diff/1/tools/DumpRecord.cpp File tools/DumpRecord.cpp (right): https://codereview.chromium.org/282233003/diff/1/tools/DumpRecord.cpp#newcode11 tools/DumpRecord.cpp:11: #include "LazyDecodeBitmap.h" Should be you can prune a bunch ...
6 years, 7 months ago (2014-05-15 15:44:08 UTC) #2
hal.canary
https://codereview.chromium.org/282233003/diff/1/tools/DumpRecord.cpp File tools/DumpRecord.cpp (right): https://codereview.chromium.org/282233003/diff/1/tools/DumpRecord.cpp#newcode11 tools/DumpRecord.cpp:11: #include "LazyDecodeBitmap.h" On 2014/05/15 15:44:08, mtklein wrote: > Should ...
6 years, 7 months ago (2014-05-15 15:59:27 UTC) #3
mtklein
lgtm
6 years, 7 months ago (2014-05-15 16:04:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/282233003/20001
6 years, 7 months ago (2014-05-15 16:04:29 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 16:10:54 UTC) #6
Message was sent while issue was closed.
Change committed as 14751

Powered by Google App Engine
This is Rietveld 408576698