Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 2822323002: More work on finalization of recursive types (fixes #29357). (Closed)

Created:
3 years, 8 months ago by regis
Modified:
3 years, 8 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More work on finalization of recursive types (fixes #29357). Add regression test. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/4dd686e9df092a80a03f1a05dc5d2db2fe113dcb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -38 lines) Patch
M runtime/vm/class_finalizer.cc View 6 chunks +48 lines, -18 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 15 chunks +28 lines, -17 lines 0 comments Download
A tests/language/regress_29357_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
3 years, 8 months ago (2017-04-18 22:42:26 UTC) #2
rmacnak
lgtm
3 years, 8 months ago (2017-04-19 00:16:38 UTC) #3
regis
3 years, 8 months ago (2017-04-19 00:18:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4dd686e9df092a80a03f1a05dc5d2db2fe113dcb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698