cc/trees/effect_node.h - Issue 2822303003: cc : Compute subtree has copy requests before property tree building

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: cc/trees/effect_node.h

Issue 2822303003: cc : Compute subtree has copy requests before property tree building (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CC_TREES_EFFECT_NODE_H_	5 #ifndef CC_TREES_EFFECT_NODE_H_

6 #define CC_TREES_EFFECT_NODE_H_	6 #define CC_TREES_EFFECT_NODE_H_

7	7

8 #include "cc/base/filter_operations.h"	8 #include "cc/base/filter_operations.h"

9 #include "cc/cc_export.h"	9 #include "cc/cc_export.h"

10 #include "third_party/skia/include/core/SkBlendMode.h"	10 #include "third_party/skia/include/core/SkBlendMode.h"

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 // TODO(jaydasika) : Delete this after implementation of	51 // TODO(jaydasika) : Delete this after implementation of

52 // SetHideLayerAndSubtree is cleaned up. (crbug.com/595843)	52 // SetHideLayerAndSubtree is cleaned up. (crbug.com/595843)

53 bool subtree_hidden;	53 bool subtree_hidden;

54 bool has_potential_filter_animation;	54 bool has_potential_filter_animation;

55 bool has_potential_opacity_animation;	55 bool has_potential_opacity_animation;

56 bool is_currently_animating_filter;	56 bool is_currently_animating_filter;

57 bool is_currently_animating_opacity;	57 bool is_currently_animating_opacity;

58 // We need to track changes to effects on the compositor to compute damage	58 // We need to track changes to effects on the compositor to compute damage

59 // rect.	59 // rect.

60 bool effect_changed;	60 bool effect_changed;

61 int num_copy_requests_in_subtree;	61 bool subtree_has_copy_request;
jaydasika 2017/04/19 02:20:34 We need not track the number. The only thing we ar We need not track the number. The only thing we are interested is whether there are copy requests.
62 int transform_id;	62 int transform_id;

63 int clip_id;	63 int clip_id;

64 // Effect node id of which this effect contributes to.	64 // Effect node id of which this effect contributes to.

65 int target_id;	65 int target_id;

66 int mask_layer_id;	66 int mask_layer_id;

67	67

68 bool operator==(const EffectNode& other) const;	68 bool operator==(const EffectNode& other) const;

69	69

70 void AsValueInto(base::trace_event::TracedValue* value) const;	70 void AsValueInto(base::trace_event::TracedValue* value) const;

71 };	71 };

72	72

73 } // namespace cc	73 } // namespace cc

74	74

75 #endif // CC_TREES_EFFECT_NODE_H_	75 #endif // CC_TREES_EFFECT_NODE_H_

OLD	NEW

« cc/trees/draw_property_utils.cc ('K') | « cc/trees/draw_property_utils.cc ('k') | cc/trees/effect_node.cc » ('j') | cc/trees/property_tree_builder.cc » ('J')