Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2822243002: Fixup jumbo.gni (-Wno-subobject-linkage)

Created:
3 years, 8 months ago by Daniel Bratell
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixup jumbo.gni (-Wno-subobject-linkage)

Patch Set 1 #

Patch Set 2 : Fixup base scripts for mac (Objective C) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M build/jumbo.gni View 1 2 chunks +17 lines, -0 lines 0 comments Download
M build/jumbo.py View 1 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 2824663002 Patch 1

Messages

Total messages: 8 (8 generated)
Daniel Bratell
The CQ bit was checked by bratell@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-18 16:52:02 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822243002/1
3 years, 8 months ago (2017-04-18 16:52:15 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 17:11:19 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/432751)
3 years, 8 months ago (2017-04-18 17:11:19 UTC) #4
Daniel Bratell
The CQ bit was checked by bratell@opera.com to run a CQ dry run
3 years, 8 months ago (2017-04-18 19:36:45 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2822243002/20001
3 years, 8 months ago (2017-04-18 19:37:22 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-18 20:03:35 UTC) #7
commit-bot: I haz the power
3 years, 8 months ago (2017-04-18 20:03:36 UTC) #8 
Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

Powered by Google App Engine
This is Rietveld 408576698